-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keycloak_client add option to support client-x509 authentication #8973
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: boolman <[email protected]>
Signed-off-by: boolman <[email protected]>
Signed-off-by: boolman <[email protected]>
Signed-off-by: boolman <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: boolman <[email protected]>
Signed-off-by: boolman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I've added some first comments below.
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Boolman thanks for your contribution!
Just left a small comment below, about the docs.
Other than that, I am assuming (lazily not checking the code) that the simple fact of adding new keys to attributes
makes them be passed through KC's API. If that's not the case, then maybe more code is needed to ensure the new options are passed along.
Signed-off-by: boolman <[email protected]>
CC @fgruenbauer |
SUMMARY
keycloak_client is missing support for x509 client authentication,
this PR updates
client_authenticator_type
with the choiceclient-x509
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
modules/keycloak_client
ADDITIONAL INFORMATION
Below is steps to test the result with this PR applied.
Start Keycloak
docker run --rm -it -p 8080:8080 -p 8443:8443 -v ~/keycloak/certs:/certs --entrypoint=/bin/bash keycloak/keycloak:25.0 bash /certs/start.sh
Apply config
Verify