Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keycloak_realm, add organizations_enabled #8927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update keycloak_realm, add organizations_enabled #8927

wants to merge 1 commit into from

Conversation

kominoshja
Copy link

SUMMARY

Add boolean parameter to enable organizations (still an experimental keycloak feature) feature toggling for keycloak

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

community.general.keycloak_realm

@kominoshja kominoshja changed the title Update keycloak_realm.py, add organizations_enabled Update keycloak_realm, add organizations_enabled Sep 25, 2024
@ansibullbot
Copy link
Collaborator

cc @eikef @kris2kris @mattock @ndclt @thomasbach-dev
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 25, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Sep 26, 2024
@russoz
Copy link
Collaborator

russoz commented Sep 26, 2024

Hi @kominoshja
Thank you for the contribution! Please add a changelog fragment.

@russoz
Copy link
Collaborator

russoz commented Sep 26, 2024

Is the new option being consumed within the code directly from the module? I have not opened the whole file and won't be able to spend much time on it these days, but it looks like the new option is not used.

felixfontein
felixfontein reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/keycloak_realm.py
- Enables support for experimental organization feature.
aliases:
- organizationsEnabled
type: bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: bool
type: bool
version_added: 9.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch check-before-release PR will be looked at again shortly before release and merged if possible. feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kominoshja @ansibullbot @russoz @felixfontein