-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plugin for generic keycloak component #8826
base: main
Are you sure you want to change the base?
add plugin for generic keycloak component #8826
Conversation
The test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please reference to https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins for how to fix the BOTMETA issue (you need to add the module and yourself to .github/BOTMETA.yml
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the changelog fragment. New modules shouldn't have one (see https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins).
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Felix Fontein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @fivetide , thanks for your contribution!
Overall the code loogs good, I left just a couple of comments below, and as pointed before you need to add an entry for this module in the .github/BOTMETA.yml
file.
# Copyright (c) 2017, Eike Frost <[email protected]> | ||
# Copyright (c) 2021, Christophe Gilles <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update this ;-)
""" | ||
Module execution | ||
|
||
:return: | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the code is cleaner without this.
# Initialize the result object. Only "changed" seems to have special | ||
# meaning for Ansible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit redundant to describe how module results look like. And, to be fair, diff
also has special meaning for Ansible.
# Initialize the result object. Only "changed" seems to have special | |
# meaning for Ansible. | |
# Initialize the result object. Only "changed" seems to have special | |
# meaning for Ansible. |
Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
SUMMARY
This MR adds a new plugin for generic management of keycloak components. It is derived from the keycloak_realm_keys plugin, but omits the key-specific handling of secrets and certs. Instead it is possible to manage any component.
Possible examples are ThemeSelector, LocaleSelector, UserStorageProvider.
see the official docs for more information:
https://www.keycloak.org/docs/latest/server_development/index.html#_providers
ISSUE TYPE
COMPONENT NAME
keycloak_component