Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes pylint used-before-assignment error #504

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

Ruchip16
Copy link
Contributor

@Ruchip16 Ruchip16 commented Aug 8, 2024

SUMMARY

Upstream nightly tests are failing due to devel branch update and some pylint errors, this PR aims to fix that.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
bgp_global.py 
acls.py
ADDITIONAL INFORMATION
Nightly failure log: https://github.com/ansible-collections/cisco.iosxr/actions/runs/10293581547/job/28490163188

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (8f9341d) to head (70d7c95).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   76.91%   77.84%   +0.93%     
==========================================
  Files         166      176      +10     
  Lines       11298    11579     +281     
==========================================
+ Hits         8690     9014     +324     
+ Misses       2608     2565      -43     

see 114 files with indirect coverage changes

@Ruchip16 Ruchip16 merged commit dfad233 into ansible-collections:main Aug 8, 2024
48 checks passed
@Ruchip16 Ruchip16 deleted the pylint_fix branch August 8, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants