DNM Promote ec2_transit_gateway_vpc_attachment and ec2_transit_gateway_vpc_attachment_info modules and tests #2347
+5,456
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New modules: Transit Gateway VPC attachments SUMMARY Adds support for EC2 Transit Gateway VPC attachments Does not support accepting / rejecting attachments at this time. ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_transit_gateway_vpc_attachment ec2_transit_gateway_vpc_attachment_info ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9494e76
…-collections#1147) ec2_transit_gateway_vpc_attachment - retry on IncorrectState SUMMARY Follows on from ansible-collections#1110 - to retry ec2_transit_gateway_vpc_attachment failures Doing this separately because it's not in the stable-3 branch. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_transit_gateway_vpc_attachment ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3347cb0
…sible-collections#1182) Tagging fragment - Move simplest cases over to the docs fragment. Depends-On: ansible-collections#844 SUMMARY Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME changelogs/fragments/1182-tagging.yml plugins/modules/aws_glue_job.py plugins/modules/aws_msk_cluster.py plugins/modules/aws_secret.py plugins/modules/aws_step_functions_state_machine.py plugins/modules/dynamodb_table.py plugins/modules/ec2_eip.py plugins/modules/ec2_transit_gateway_vpc_attachment.py plugins/modules/ec2_vpc_peer.py plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py plugins/modules/iam_role.py plugins/modules/iam_user.py plugins/modules/networkfirewall.py plugins/modules/networkfirewall_policy.py plugins/modules/networkfirewall_rule_group.py plugins/modules/rds_cluster.py plugins/modules/rds_instance.py plugins/modules/rds_instance_snapshot.py plugins/modules/rds_option_group.py plugins/modules/rds_subnet_group.py plugins/modules/redshift.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b11ffae
…ansible-collections#1467) tests/integration: ensure the CI gives more time to some slow targets Depends-On: ansible/ansible-zuul-jobs#1625 Depends-On: ansible-collections#1468 Depends-On: ansible-collections#1473 Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@19a24e5
…ble-collections#1494) tests: dedicate more time to ec2_transit_gateway_vpc_attachment ec2_transit_gateway_vpc_attachment took 0:33:49 during the following buildset: https://ansible.softwarefactory-project.io/zuul/buildset/92340ac9ef144d5ca9e59f7cd3769451 This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@de5b804
…#1539) Make example AWS UUIDS follow a specific pattern SUMMARY Various AWS IAM resources have UUID which follow a specific pattern. Similarly AWS accounts are all 12 digit numbers (text aliases in a couple of cases). To minimize the risk of accidental data leaks use a consistent Account ID in examples (123456789012), and a specific format for the UUIDS: (AKIA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA)12345EXAMPLE54321 While this does nothing about historic data, having consistency makes it easier to prevent future leaks. Note: We should follow this up with an update to the developer docs, however I'd like to get this in prior to 5.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/acm_certificate_info.py plugins/modules/application_autoscaling_policy.py plugins/modules/autoscaling_launch_config.py plugins/modules/autoscaling_launch_config_info.py plugins/modules/codecommit_repository.py plugins/modules/directconnect_link_aggregation_group.py plugins/modules/dms_endpoint.py plugins/modules/dynamodb_table.py plugins/modules/ec2_transit_gateway_info.py plugins/modules/ec2_transit_gateway_vpc_attachment.py plugins/modules/ec2_transit_gateway_vpc_attachment_info.py plugins/modules/ec2_vpc_peer.py plugins/modules/ec2_vpc_peering_info.py plugins/modules/ec2_vpc_vpn_info.py plugins/modules/ecs_cluster.py plugins/modules/ecs_ecr.py plugins/modules/ecs_service.py plugins/modules/ecs_service_info.py plugins/modules/ecs_task.py plugins/modules/efs.py plugins/modules/efs_info.py plugins/modules/eks_cluster.py plugins/modules/elasticache_subnet_group.py plugins/modules/elb_network_lb.py plugins/modules/elb_target_group.py plugins/modules/elb_target_group_info.py plugins/modules/elb_target_info.py plugins/modules/iam_group.py plugins/modules/iam_managed_policy.py plugins/modules/iam_mfa_device_info.py plugins/modules/iam_server_certificate_info.py plugins/modules/lightsail.py plugins/modules/lightsail_static_ip.py plugins/modules/msk_cluster.py plugins/modules/s3_bucket_notification.py plugins/modules/sns_topic.py plugins/modules/sns_topic_info.py plugins/modules/sqs_queue.py plugins/modules/stepfunctions_state_machine.py plugins/modules/stepfunctions_state_machine_execution.py plugins/modules/storagegateway_info.py plugins/modules/wafv2_web_acl.py ADDITIONAL INFORMATION While the 'secret' nature of these UUIDs is debatable (they're closer to user names than passwords), deliberately mangling them makes it easier for InfoSec teams to spot when their secret counterparts may have been leaked in combination with a real 'public' part. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9476422
…collections#1459) Update extends_documentation_fragment with amazon.aws.boto3 Depends-On: ansible/ansible-zuul-jobs#1654 SUMMARY As per ansible-collections#985 add amazon.aws.boto3. ISSUE TYPE Docs Pull Request COMPONENT NAME several Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bd3c03f
…ons#1632) Ansible User-Agent identification for community.aws SUMMARY The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0 ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a8cbce2
fixed unneeded `state` in module docs. SUMMARY removed state as it does not work in the info part ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION "Unsupported parameters for (community.aws.ec2_transit_gateway_vpc_attachment_info) module: state. Supported parameters include: access_key, aws_ca_bundle, aws_config, debug_botocore_endpoint_logs, endpoint_url, filters, id, include_deleted, name, profile, region, secret_key, session_token, validate_certs (access_token, attachment_id, aws_access_key, aws_access_key_id, aws_endpoint_url, aws_profile, aws_region, aws_secret_access_key, aws_secret_key, aws_security_token, aws_session_token, ec2_access_key, ec2_region, ec2_secret_key, ec2_url, s3_url, security_token).", Reviewed-by: Mark Chappell This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b5eefc1
Cleanup headers and imports SUMMARY Mass update of imports, docs fragments and file headers Many of the amazon.aws module_utils and docs fragments got moved about, update community.aws to reflect this. Consistently apply the comment headers as documented at https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Header cleanup based upon: https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding Begin your Ansible module with #!/usr/bin/python - this “shebang” allows ansible_python_interpreter to work. Follow the shebang immediately with # -*- coding: utf-8 -*- to clarify that the file is UTF-8 encoded. and https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#copyright-and-license After the shebang and UTF-8 coding, add a copyright line with the original copyright holder and a license declaration. The license declaration should be ONLY one line, not the full GPL prefix. ... Additions to the module (for instance, rewrites) are not permitted to add additional copyright lines other than the default copyright statement if missing: Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a4f20bf
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2c4575c
…ollections#1921) Mass update of docs and tests (credentials/session tokens) SUMMARY We had a cleanup of credentials/session parameters which included a batch of deprecations and renames. Ensure that all of our tests and docs are using the 'canonical' names ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/batch_compute_environment.py plugins/modules/cloudformation_exports_info.py plugins/modules/ec2_vpc_vpn.py plugins/modules/elasticache.py plugins/modules/elasticache_parameter_group.py plugins/modules/elasticache_snapshot.py plugins/modules/ses_rule_set.py plugins/modules/sts_assume_role.py plugins/modules/sts_session_token.py tests/integration ADDITIONAL INFORMATION See also ansible-collections#1172 ansible-collections#1714 Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4a5b50e
…s#2036) ansible-lint (documentation) cleanup for plugins/ SUMMARY Fixes an array of ansible-lint failures in plugins/ Adds ansible-lint plugins/ to tox -m lint ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/ ADDITIONAL INFORMATION docs changes only (no changelog fragment needed) Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@6dd4a00
…ns#2063) SUMMARY Need to enable multicast while creating transit gateway ISSUE TYPE Feature Pull Request COMPONENT NAME transit_gateway ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Carlos Schimidt Reviewed-by: Mark Chappell This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4752c05
…amazon.aws (ansible-collections#2157) SUMMARY Refer: https://issues.redhat.com/browse/ACA-1868 This PR refactors and adds necessary documentation to ec2_transit_gateway_vpc_attachment and ec2_transit_gateway_vpc_attachment_info ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7dabfcc
Signed-off-by: Alina Buzachis <[email protected]>
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_tag_info_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_tag_info_module.html
index ba366c4..a90e364 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_tag_info_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_tag_info_module.html
@@ -22,7 +22,7 @@
<script src="../../../_static/sphinx_highlight.js?v=dc90522c"></script>
<script src="../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../search.html" />
- <link rel="next" title="amazon.aws.ec2_vol module – Create and attach a volume, return volume ID and device map" href="ec2_vol_module.html" />
+ <link rel="next" title="amazon.aws.ec2_transit_gateway_vpc_attachment module – Create and delete AWS Transit Gateway VPC attachments" href="ec2_transit_gateway_vpc_attachment_module.html" />
<link rel="prev" title="amazon.aws.ec2_tag module – Create and remove tags on ec2 resources" href="ec2_tag_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -399,7 +399,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-ec2-tag-
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
<a href="ec2_tag_module.html" class="btn btn-neutral float-left" title="amazon.aws.ec2_tag module – Create and remove tags on ec2 resources" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
- <a href="ec2_vol_module.html" class="btn btn-neutral float-right" title="amazon.aws.ec2_vol module – Create and attach a volume, return volume ID and device map" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
+ <a href="ec2_transit_gateway_vpc_attachment_module.html" class="btn btn-neutral float-right" title="amazon.aws.ec2_transit_gateway_vpc_attachment module – Create and delete AWS Transit Gateway VPC attachments" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
<hr/>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_vol_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_vol_module.html
index f7b8b64..4089200 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_vol_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_vol_module.html
@@ -23,7 +23,7 @@
<script src="../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../search.html" />
<link rel="next" title="amazon.aws.ec2_vol_info module – Gather information about EC2 volumes in AWS" href="ec2_vol_info_module.html" />
- <link rel="prev" title="amazon.aws.ec2_tag_info module – List tags on ec2 resources" href="ec2_tag_info_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
+ <link rel="prev" title="amazon.aws.ec2_transit_gateway_vpc_attachment_info module – describes AWS Transit Gateway VPC attachments" href="ec2_transit_gateway_vpc_attachment_info_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -795,7 +795,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-ec2-vol-
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
- <a href="ec2_tag_info_module.html" class="btn btn-neutral float-left" title="amazon.aws.ec2_tag_info module – List tags on ec2 resources" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
+ <a href="ec2_transit_gateway_vpc_attachment_info_module.html" class="btn btn-neutral float-left" title="amazon.aws.ec2_transit_gateway_vpc_attachment_info module – describes AWS Transit Gateway VPC attachments" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
<a href="ec2_vol_info_module.html" class="btn btn-neutral float-right" title="amazon.aws.ec2_vol_info module – Gather information about EC2 volumes in AWS" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/index.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/index.html
index d0294a8..a0eaf3d 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/index.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/index.html
@@ -261,6 +261,8 @@
<li><p><a class="reference internal" href="ec2_spot_instance_info_module.html#ansible-collections-amazon-aws-ec2-spot-instance-info-module"><span class="std std-ref">ec2_spot_instance_info module</span></a> – Gather information about ec2 spot instance requests</p></li>
<li><p><a class="reference internal" href="ec2_tag_module.html#ansible-collections-amazon-aws-ec2-tag-module"><span class="std std-ref">ec2_tag module</span></a> – Create and remove tags on ec2 resources</p></li>
<li><p><a class="reference internal" href="ec2_tag_info_module.html#ansible-collections-amazon-aws-ec2-tag-info-module"><span class="std std-ref">ec2_tag_info module</span></a> – List tags on ec2 resources</p></li>
+<li><p><a class="reference internal" href="ec2_transit_gateway_vpc_attachment_module.html#ansible-collections-amazon-aws-ec2-transit-gateway-vpc-attachment-module"><span class="std std-ref">ec2_transit_gateway_vpc_attachment module</span></a> – Create and delete AWS Transit Gateway VPC attachments</p></li>
+<li><p><a class="reference internal" href="ec2_transit_gateway_vpc_attachment_info_module.html#ansible-collections-amazon-aws-ec2-transit-gateway-vpc-attachment-info-module"><span class="std std-ref">ec2_transit_gateway_vpc_attachment_info module</span></a> – describes AWS Transit Gateway VPC attachments</p></li>
<li><p><a class="reference internal" href="ec2_vol_module.html#ansible-collections-amazon-aws-ec2-vol-module"><span class="std std-ref">ec2_vol module</span></a> – Create and attach a volume, return volume ID and device map</p></li>
<li><p><a class="reference internal" href="ec2_vol_info_module.html#ansible-collections-amazon-aws-ec2-vol-info-module"><span class="std std-ref">ec2_vol_info module</span></a> – Gather information about EC2 volumes in AWS</p></li>
<li><p><a class="reference internal" href="ec2_vpc_dhcp_option_module.html#ansible-collections-amazon-aws-ec2-vpc-dhcp-option-module"><span class="std std-ref">ec2_vpc_dhcp_option module</span></a> – Manages DHCP Options, and can ensure the DHCP options for the given VPC match what’s requested</p></li>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/index_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/index_module.html
index 45fc8fb..39226b2 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/index_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/index_module.html
@@ -169,6 +169,8 @@
<li><p><a class="reference internal" href="amazon/aws/ec2_spot_instance_info_module.html#ansible-collections-amazon-aws-ec2-spot-instance-info-module"><span class="std std-ref">amazon.aws.ec2_spot_instance_info</span></a> – Gather information about ec2 spot instance requests</p></li>
<li><p><a class="reference internal" href="amazon/aws/ec2_tag_module.html#ansible-collections-amazon-aws-ec2-tag-module"><span class="std std-ref">amazon.aws.ec2_tag</span></a> – Create and remove tags on ec2 resources</p></li>
<li><p><a class="reference internal" href="amazon/aws/ec2_tag_info_module.html#ansible-collections-amazon-aws-ec2-tag-info-module"><span class="std std-ref">amazon.aws.ec2_tag_info</span></a> – List tags on ec2 resources</p></li>
+<li><p><a class="reference internal" href="amazon/aws/ec2_transit_gateway_vpc_attachment_module.html#ansible-collections-amazon-aws-ec2-transit-gateway-vpc-attachment-module"><span class="std std-ref">amazon.aws.ec2_transit_gateway_vpc_attachment</span></a> – Create and delete AWS Transit Gateway VPC attachments</p></li>
+<li><p><a class="reference internal" href="amazon/aws/ec2_transit_gateway_vpc_attachment_info_module.html#ansible-collections-amazon-aws-ec2-transit-gateway-vpc-attachment-info-module"><span class="std std-ref">amazon.aws.ec2_transit_gateway_vpc_attachment_info</span></a> – describes AWS Transit Gateway VPC attachments</p></li>
<li><p><a class="reference internal" href="amazon/aws/ec2_vol_module.html#ansible-collections-amazon-aws-ec2-vol-module"><span class="std std-ref">amazon.aws.ec2_vol</span></a> – Create and attach a volume, return volume ID and device map</p></li>
<li><p><a class="reference internal" href="amazon/aws/ec2_vol_info_module.html#ansible-collections-amazon-aws-ec2-vol-info-module"><span class="std std-ref">amazon.aws.ec2_vol_info</span></a> – Gather information about EC2 volumes in AWS</p></li>
<li><p><a class="reference internal" href="amazon/aws/ec2_vpc_dhcp_option_module.html#ansible-collections-amazon-aws-ec2-vpc-dhcp-option-module"><span class="std std-ref">amazon.aws.ec2_vpc_dhcp_option</span></a> – Manages DHCP Options, and can ensure the DHCP options for the given VPC match what’s requested</p></li>
|
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 02s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 6m 11s |
alinabuzachis
force-pushed
the
promote_ec2_transit_gateway_vpc_attachment
branch
from
0453635
to
43ac0b1
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s |
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
promote_ec2_transit_gateway_vpc_attachment
branch
from
43ac0b1
to
513d4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Promote ec2_transit_gateway_vpc_attachment and ec2_transit_gateway_vpc_attachment_info modules and tests
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION