Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM - Migrate modules ec2_vpc_egress_igw and tests #2327

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Commits on Oct 15, 2024

  1. Initial commit

    jillr authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7b57fea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34e576c View commit details
    Browse the repository at this point in the history
  3. Rename collection (ansible-collections#12)

    * Rename core collection
    
    Rename references to ansible.amazon to amazon.aws.
    
    * Rename community.amazon to community.aws
    Fix pep8 line lengths for rewritten amazon.aws imports
    
    * Missed a path in shippable.sh
    * Dependency repos moved
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@235c5db
    jillr authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d41c47b View commit details
    Browse the repository at this point in the history
  4. Remove METADATA and cleanup galaxy.yml (ansible-collections#70)

    * Remove ANSIBLE_METADATA entirely, see ansible/ansible/pull/69454.
    Remove `license` field from galaxy.yml, in favor of `license_file`.
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@05672a6
    jillr authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8e346fc View commit details
    Browse the repository at this point in the history
  5. Update Examples with FQCN (ansible-collections#67)

    Updated module examples with FQCN
    
    Signed-off-by: Abhijeet Kasurde <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@98173ae
    Akasurde authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2b690aa View commit details
    Browse the repository at this point in the history
  6. Update module_utils paths to remove aws subdir (ansible-collections#23)

    Co-authored-by: Ezekiel Hendrickson <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@10853d9
    2 people authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cabe3d1 View commit details
    Browse the repository at this point in the history
  7. Update docs (ansible-collections#99)

    * Update docs
    
    Remove .git from repo url so links in readme will generate correctly
    Add required ansible version
    Run latest version of add_docs.py
    Add version_added string to modules
    
    * galaxy.yml was missing authors
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@96ee268
    jillr authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0e9961a View commit details
    Browse the repository at this point in the history
  8. Bulk migration to AnsibleAWSModule (ansible-collections#173)

    * Update comments to reference AnsibleAWSModule rather than AnsibleModule
    * Bulk re-order imports and split onto one from import per-line.
    * Add AnsibleAWSModule imports
    * Migrate boto 2 based modules to AnsibleAWSModule
    * Move boto3-only modules over to AnsibleAWSModule
    * Remove extra ec2_argument_spec calls - not needed now we're using AnsibleAWSModule
    * Remove most HAS_BOTO3 code, it's handled by AnsibleAWSModule
    * Handle missing Boto 2 consistently  (HAS_BOTO)
    * Remove AnsibleModule imports
    * Changelog fragment
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@818c6d2
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ebff9a0 View commit details
    Browse the repository at this point in the history
  9. Cleanup - use is_boto3_error_(message|code) (ansible-collections#268)

    * Reorder imports
    * Make use of is_boto3_error_message
    * Mass-migration over to is_boto3_error_code
    * Remove unused imports
    * unused vars in exception
    * Improve consistency around catching BotoCoreError and ClientError
    * Remove unused imports
    * Remove unused 'PolicyError' from iam_policy_info
    * Avoid catching botocore.exceptions.ClientError when we only want some error codes
    * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4cf52ef
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e5bd49f View commit details
    Browse the repository at this point in the history
  10. Move tests to using module_defaults (ansible-collections#368)

    * Bulk migration to module_defaults
    * Tests for missing creds/region
    * Move dms_identifier and dms_sg_identifier into defaults
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@365b6ef
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cc22847 View commit details
    Browse the repository at this point in the history
  11. Add retries to ec2_vpc_egress_igw (ansible-collections#421)

    * ec2_vpc_egress_igw - use connection rather than 'conn' for consistency
    
    * ec2_vpc_egress_igw - enable retry decorator
    
    * changelog
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@f2d4851
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1c77177 View commit details
    Browse the repository at this point in the history
  12. Remove shippable references from repo

    This collection has been operating on Zuul CI for some weeks now
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4e0d83c
    jillr authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    83120a1 View commit details
    Browse the repository at this point in the history
  13. For consistency - add empty dependencies file to targets with no curr…

    …ent meta data (ansible-collections#1090)
    
    For consistency - add empty dependencies file to targets with no current meta data
    
    SUMMARY
    For consistency - add empty dependencies file to targets with no current meta data
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    tests/integration/targets
    ADDITIONAL INFORMATION
    
    Reviewed-by: Alina Buzachis <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@9638580
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    93564ed View commit details
    Browse the repository at this point in the history
  14. tests/ec2_vpc_egress_igw: avoid a InvalidVpcId.Malformed error (ansib…

    …le-collections#1475)
    
    tests/ec2_vpc_egress_igw: avoid a InvalidVpcId.Malformed error
    
    Ensures the "test failure with non-existent VPC ID" test uses a properly
    formatted VPC ID.
    Otherwise, the API now returns the following error:
    "error": {
        "code": "InvalidVpcId.Malformed",
        "message": "The vpc ID vpc-012345678 is malformed"
    },
    
    Reviewed-by: Mark Chappell <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@fe83fcb
    goneri authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    63bf159 View commit details
    Browse the repository at this point in the history
  15. Update extends_documentation_fragment with amazon.aws.boto3 (ansible-…

    …collections#1459)
    
    Update extends_documentation_fragment with amazon.aws.boto3
    
    Depends-On: ansible/ansible-zuul-jobs#1654
    SUMMARY
    
    As per ansible-collections#985 add amazon.aws.boto3.
    
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    
    several
    
    Reviewed-by: Jill R <None>
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Markus Bergholz <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@bd3c03f
    alinabuzachis authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1350fbd View commit details
    Browse the repository at this point in the history
  16. Ansible User-Agent identification for community.aws (ansible-collecti…

    …ons#1632)
    
    Ansible User-Agent identification for community.aws
    
    SUMMARY
    
    The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0
    
    ISSUE TYPE
    
    Feature Pull Request
    
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Bikouo Aubin <None>
    Reviewed-by: Alina Buzachis <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@a8cbce2
    abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6c77133 View commit details
    Browse the repository at this point in the history
  17. Cleanup headers and imports (ansible-collections#1738)

    Cleanup headers and imports
    
    SUMMARY
    Mass update of imports, docs fragments and file headers
    
    Many of the amazon.aws module_utils and docs fragments got moved about, update community.aws to reflect this.
    Consistently apply the comment headers as documented at https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding
    
    ISSUE TYPE
    
    Docs Pull Request
    Feature Pull Request
    
    COMPONENT NAME
    ADDITIONAL INFORMATION
    Header cleanup based upon:
    https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding
    
    Begin your Ansible module with #!/usr/bin/python - this “shebang” allows ansible_python_interpreter to work. Follow the shebang immediately with # -*- coding: utf-8 -*- to clarify that the file is UTF-8 encoded.
    
    and
    https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#copyright-and-license
    
    After the shebang and UTF-8 coding, add a copyright line with the original copyright holder and a license declaration. The license declaration should be ONLY one line, not the full GPL prefix.
    ...
    Additions to the module (for instance, rewrites) are not permitted to add additional copyright lines other than the default copyright statement if missing:
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@a4f20bf
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0c39df2 View commit details
    Browse the repository at this point in the history
  18. Big Black PR (ansible-collections#1784)

    * Black prep
    
    * Black
    
    * changelog
    
    * Fix pylint unused-import in tests
    
    * Split SSM connection plugin changes
    
    * disable glue tests - bucket's missing
    
    * Disable s3_logging and s3_sync tests
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@2c4575c
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1355b7d View commit details
    Browse the repository at this point in the history
  19. Bulk migration to Python 3.6 f-strings (ansible-collections#1810)

    Bulk migration to Python 3.6 f-strings
    
    SUMMARY
    We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup
    A combination of
    
    black --preview
    flynt
    some manual cleanup
    
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    plugins/
    tests/
    ADDITIONAL INFORMATION
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@de33821
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6d2f829 View commit details
    Browse the repository at this point in the history
  20. Mass update of docs and tests (credentials/session tokens) (ansible-c…

    …ollections#1921)
    
    Mass update of docs and tests (credentials/session tokens)
    
    SUMMARY
    We had a cleanup of credentials/session parameters which included a batch of deprecations and renames.
    Ensure that all of our tests and docs are using the 'canonical' names
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    plugins/modules/batch_compute_environment.py
    plugins/modules/cloudformation_exports_info.py
    plugins/modules/ec2_vpc_vpn.py
    plugins/modules/elasticache.py
    plugins/modules/elasticache_parameter_group.py
    plugins/modules/elasticache_snapshot.py
    plugins/modules/ses_rule_set.py
    plugins/modules/sts_assume_role.py
    plugins/modules/sts_session_token.py
    tests/integration
    ADDITIONAL INFORMATION
    See also
    
    ansible-collections#1172
    ansible-collections#1714
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4a5b50e
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    61245f0 View commit details
    Browse the repository at this point in the history
  21. ansible-lint (documentation) cleanup for plugins/ (ansible-collection…

    …s#2036)
    
    ansible-lint (documentation) cleanup for plugins/
    
    SUMMARY
    Fixes an array of ansible-lint failures in plugins/
    Adds ansible-lint plugins/ to tox -m lint
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    plugins/
    ADDITIONAL INFORMATION
    docs changes only (no changelog fragment needed)
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@6dd4a00
    tremble authored and abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    34bc7bd View commit details
    Browse the repository at this point in the history
  22. Prepare modules ec2_vpc_egress_igw for promotion (ansible-collections…

    …#2152)
    
    SUMMARY
    
    Refactor module ec2_vpc_egress_igw to use shared code from amazon.aws.plugins.module_utils.ec2
    ec2_vpc_egress_igw - add support for tagging
    
    ISSUE TYPE
    
    Feature Pull Request
    New Module Pull Request
    
    COMPONENT NAME
    
    ec2_vpc_egress_igw
    
    Reviewed-by: Alina Buzachis
    Reviewed-by: Bikouo Aubin
    Reviewed-by: GomathiselviS
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@7b51659
    abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    dd35176 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    4495c26 View commit details
    Browse the repository at this point in the history
  24. add changelog file

    abikouo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f76958a View commit details
    Browse the repository at this point in the history