New module - autoscaling_instance(_info) #2296
Conversation
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/autoscaling_group_info_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/autoscaling_group_info_module.html
index e4998b5..7af01c7 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/autoscaling_group_info_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/autoscaling_group_info_module.html
@@ -22,7 +22,7 @@
<script src="../../../_static/sphinx_highlight.js?v=dc90522c"></script>
<script src="../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../search.html" />
- <link rel="next" title="amazon.aws.aws_az_info module – Gather information about availability zones in AWS" href="aws_az_info_module.html" />
+ <link rel="next" title="amazon.aws.autoscaling_instance module – manage instances associated with AWS AutoScaling Groups (ASGs)" href="autoscaling_instance_module.html" />
<link rel="prev" title="amazon.aws.autoscaling_group module – Create or delete AWS AutoScaling Groups (ASGs)" href="autoscaling_group_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -810,7 +810,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-autoscal
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
<a href="autoscaling_group_module.html" class="btn btn-neutral float-left" title="amazon.aws.autoscaling_group module – Create or delete AWS AutoScaling Groups (ASGs)" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
- <a href="aws_az_info_module.html" class="btn btn-neutral float-right" title="amazon.aws.aws_az_info module – Gather information about availability zones in AWS" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
+ <a href="autoscaling_instance_module.html" class="btn btn-neutral float-right" title="amazon.aws.autoscaling_instance module – manage instances associated with AWS AutoScaling Groups (ASGs)" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
<hr/>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/aws_az_info_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/aws_az_info_module.html
index 48ee019..b0a9f8c 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/aws_az_info_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/aws_az_info_module.html
@@ -23,7 +23,7 @@
<script src="../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../search.html" />
<link rel="next" title="amazon.aws.aws_caller_info module – Get information about the user and account being used to make AWS calls" href="aws_caller_info_module.html" />
- <link rel="prev" title="amazon.aws.autoscaling_group_info module – Gather information about EC2 Auto Scaling Groups (ASGs) in AWS" href="autoscaling_group_info_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
+ <link rel="prev" title="amazon.aws.autoscaling_instance_info module – describe instances associated with AWS AutoScaling Groups (ASGs)" href="autoscaling_instance_info_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -500,7 +500,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-aws-az-i
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
- <a href="autoscaling_group_info_module.html" class="btn btn-neutral float-left" title="amazon.aws.autoscaling_group_info module – Gather information about EC2 Auto Scaling Groups (ASGs) in AWS" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
+ <a href="autoscaling_instance_info_module.html" class="btn btn-neutral float-left" title="amazon.aws.autoscaling_instance_info module – describe instances associated with AWS AutoScaling Groups (ASGs)" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
<a href="aws_caller_info_module.html" class="btn btn-neutral float-right" title="amazon.aws.aws_caller_info module – Get information about the user and account being used to make AWS calls" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/index.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/index.html
index e9d5788..1a2e0d5 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/index.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/index.html
@@ -217,6 +217,8 @@
<ul class="simple">
<li><p><a class="reference internal" href="autoscaling_group_module.html#ansible-collections-amazon-aws-autoscaling-group-module"><span class="std std-ref">autoscaling_group module</span></a> – Create or delete AWS AutoScaling Groups (ASGs)</p></li>
<li><p><a class="reference internal" href="autoscaling_group_info_module.html#ansible-collections-amazon-aws-autoscaling-group-info-module"><span class="std std-ref">autoscaling_group_info module</span></a> – Gather information about EC2 Auto Scaling Groups (ASGs) in AWS</p></li>
+<li><p><a class="reference internal" href="autoscaling_instance_module.html#ansible-collections-amazon-aws-autoscaling-instance-module"><span class="std std-ref">autoscaling_instance module</span></a> – manage instances associated with AWS AutoScaling Groups (ASGs)</p></li>
+<li><p><a class="reference internal" href="autoscaling_instance_info_module.html#ansible-collections-amazon-aws-autoscaling-instance-info-module"><span class="std std-ref">autoscaling_instance_info module</span></a> – describe instances associated with AWS AutoScaling Groups (ASGs)</p></li>
<li><p><a class="reference internal" href="aws_az_info_module.html#ansible-collections-amazon-aws-aws-az-info-module"><span class="std std-ref">aws_az_info module</span></a> – Gather information about availability zones in AWS</p></li>
<li><p><a class="reference internal" href="aws_caller_info_module.html#ansible-collections-amazon-aws-aws-caller-info-module"><span class="std std-ref">aws_caller_info module</span></a> – Get information about the user and account being used to make AWS calls</p></li>
<li><p><a class="reference internal" href="aws_region_info_module.html#ansible-collections-amazon-aws-aws-region-info-module"><span class="std std-ref">aws_region_info module</span></a> – Gather information about AWS regions</p></li>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/index_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/index_module.html
index 411f5f1..d7203ed 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/index_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/index_module.html
@@ -125,6 +125,8 @@
<ul class="simple">
<li><p><a class="reference internal" href="amazon/aws/autoscaling_group_module.html#ansible-collections-amazon-aws-autoscaling-group-module"><span class="std std-ref">amazon.aws.autoscaling_group</span></a> – Create or delete AWS AutoScaling Groups (ASGs)</p></li>
<li><p><a class="reference internal" href="amazon/aws/autoscaling_group_info_module.html#ansible-collections-amazon-aws-autoscaling-group-info-module"><span class="std std-ref">amazon.aws.autoscaling_group_info</span></a> – Gather information about EC2 Auto Scaling Groups (ASGs) in AWS</p></li>
+<li><p><a class="reference internal" href="amazon/aws/autoscaling_instance_module.html#ansible-collections-amazon-aws-autoscaling-instance-module"><span class="std std-ref">amazon.aws.autoscaling_instance</span></a> – manage instances associated with AWS AutoScaling Groups (ASGs)</p></li>
+<li><p><a class="reference internal" href="amazon/aws/autoscaling_instance_info_module.html#ansible-collections-amazon-aws-autoscaling-instance-info-module"><span class="std std-ref">amazon.aws.autoscaling_instance_info</span></a> – describe instances associated with AWS AutoScaling Groups (ASGs)</p></li>
<li><p><a class="reference internal" href="amazon/aws/aws_az_info_module.html#ansible-collections-amazon-aws-aws-az-info-module"><span class="std std-ref">amazon.aws.aws_az_info</span></a> – Gather information about availability zones in AWS</p></li>
<li><p><a class="reference internal" href="amazon/aws/aws_caller_info_module.html#ansible-collections-amazon-aws-aws-caller-info-module"><span class="std std-ref">amazon.aws.aws_caller_info</span></a> – Get information about the user and account being used to make AWS calls</p></li>
<li><p><a class="reference internal" href="amazon/aws/aws_region_info_module.html#ansible-collections-amazon-aws-aws-region-info-module"><span class="std std-ref">amazon.aws.aws_region_info</span></a> – Gather information about AWS regions</p></li>
|
tremble
force-pushed
the
autoscaling/instances
branch
from
43d99b1
to
d4d2b4b
Compare
tremble
force-pushed
the
autoscaling/instances
branch
from
d4d2b4b
to
6d534b0
Compare
tremble
changed the title
tremble
force-pushed
the
autoscaling/instances
branch
2 times, most recently
from
fdd68ad
to
425286c
Compare
SUMMARY Having everything in waiters.py today means that every time we add a new waiter we trigger a lot of integration tests. Adding this Factory gives us a basis to work upon for splitting the code up. It's based upon the Factory in community.aws, but doesn't come with the assumption that we'll have the module/client available to us when we instantiate the factory. While similar to the current code in waiters.py, this factory supports: waiter definitions stored on a per-API basis waiter definitions outside of amazon.aws Because touching the existing waiters.py would trigger a mass of integration tests, this puts the factory into waiter.py instead of waiters.py. Additionally, putting it in waiter.py also gives us a long term route to split the current waiters off and out of waiters.py without generating import loops. (Putting it in waiters.py would mean that a per-API file would need to import waiters.py, and thus waiters.py couldn't import the new file to provide backwards compatibility with today's implementation) ISSUE TYPE Feature Pull Request COMPONENT NAME plugin/module_utils/waiter.py ADDITIONAL INFORMATION See #2296 for an example of using this (module_utils._autoscaling.waiters) Reviewed-by: Alina Buzachis
tremble
force-pushed
the
autoscaling/instances
branch
from
df9061f
to
246d2be
Compare
| - ansible.builtin.include_tasks: health.yml | ||
| - ansible.builtin.include_tasks: protection.yml |
There was a problem hiding this comment.
With permission changes it's getting further, but these files don't exist so it's failing here, now.
There was a problem hiding this comment.
Uploaded now, sorry.
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s |
tremble
force-pushed
the
autoscaling/instances
branch
from
73eca48
to
beacb22
Compare
|
Build failed.
|
Depends-On: ansible/ansible-zuul-jobs#1885
SUMMARY
Looking to simplify autoscaling_group, add autoscaling_instance as a new module so we can deprecate support for it in autoscaling_group
ISSUE TYPE
COMPONENT NAME
autoscaling_instance
ADDITIONAL INFORMATION