Merge pull request #65 from ans-group/volume-port-attribute

Volume port attribute
ans-group · Jul 15, 2024 · f5845ad · f5845ad
2 parents 1ca9e04 + 73fa9ea
commit f5845ad
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/docs/data-sources/ecloud_volume.md b/docs/data-sources/ecloud_volume.md
@@ -19,6 +19,7 @@ data "ecloud_volume" "volume-1" {
 - `capacity`: Capacity of volume
 - `iops`: IOPs of volume
 - `volume_group_id`: ID of volume volumegroup 
+- `port`: Port number of volume (when member of a volume group)
 
 ## Attributes Reference
 
@@ -29,4 +30,5 @@ data "ecloud_volume" "volume-1" {
 - `availability_zone_id`: ID of volume availability zone
 - `capacity`: Capacity of volume
 - `iops`: IOPs of volume
-- `volume_group_id`: ID of volume volumegroup 
+- `volume_group_id`: ID of volume volumegroup
+- `port`: Port number of volume (when member of a volume group)
diff --git a/docs/resources/ecloud_volume.md b/docs/resources/ecloud_volume.md
@@ -35,4 +35,5 @@ resource "ecloud_volume" "volume-1" {
 - `name`: Name of volume
 - `capacity`: Volume size in GiB
 - `iops`: IOPS of volume
-- `volume_group_id`: ID of the volumegroup that the volume is a member of
+- `volume_group_id`: ID of the volume group that the volume is a member of
+- `port`: Port number of volume (when member of a volume group)
diff --git a/ecloud/data_source_volume.go b/ecloud/data_source_volume.go
@@ -43,6 +43,10 @@ func dataSourceVolume() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 			},
+			"port": {
+				Type:     schema.TypeInt,
+				Optional: true,
+			},
 		},
 	}
 }
@@ -73,6 +77,9 @@ func dataSourceVolumeRead(ctx context.Context, d *schema.ResourceData, meta inte
 	if volumeGroupID, ok := d.GetOk("volume_group_id"); ok {
 		params.WithFilter(*connection.NewAPIRequestFiltering("volume_group_id", connection.EQOperator, []string{volumeGroupID.(string)}))
 	}
+	if port, ok := d.GetOk("port"); ok {
+		params.WithFilter(*connection.NewAPIRequestFiltering("port", connection.EQOperator, []string{strconv.Itoa(port.(int))}))
+	}
 
 	volumes, err := service.GetVolumes(params)
 	if err != nil {
@@ -94,6 +101,7 @@ func dataSourceVolumeRead(ctx context.Context, d *schema.ResourceData, meta inte
 	d.Set("vpc_id", volumes[0].VPCID)
 	d.Set("availability_zone_id", volumes[0].AvailabilityZoneID)
 	d.Set("volume_group_id", volumes[0].VolumeGroupID)
+	d.Set("port", volumes[0].Port)
 
 	return nil
 }
diff --git a/ecloud/resource_volume.go b/ecloud/resource_volume.go
@@ -70,7 +70,6 @@ func resourceVolume() *schema.Resource {
 			},
 			"port": {
 				Type:     schema.TypeInt,
-				Optional: true,
 				Computed: true,
 			},
 		},