Skip to content
CI checks

rename the vp(validity predicate) as resource logic #542

Sign in to view logs

rename the vp(validity predicate) as resource logic

rename the vp(validity predicate) as resource logic #542

GitHub Actions / Clippy (beta) succeeded Aug 21, 2024 in 1s

Clippy (beta)

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.81.0-beta.5 (6c199c89c 2024-08-15)
  • cargo 1.81.0-beta.5 (ca2346bd3 2024-07-31)
  • clippy 0.1.81 (6c199c8 2024-08-15)

Annotations

Check warning on line 55 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

empty doc comment 

warning: empty doc comment
  --> taiga_halo2/src/taiga_api.rs:55:1
   |
55 | ///
   | ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `-W clippy::empty-docs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`

Check warning on line 55 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

empty doc comment 

warning: empty doc comment
  --> taiga_halo2/src/taiga_api.rs:55:1
   |
55 | ///
   | ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `-W clippy::empty-docs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`

Check warning on line 566 in taiga_halo2/src/circuit/blake2s.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of a legacy numeric method 

warning: usage of a legacy numeric method
   --> taiga_halo2/src/circuit/blake2s.rs:566:57
    |
566 |             Blake2sWord::from_constant_u32(IV[6] ^ u32::max_value(), layouter, self)?
    |                                                         ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    = note: `-W clippy::legacy-numeric-constants` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::legacy_numeric_constants)]`
help: use the associated constant instead
    |
566 |             Blake2sWord::from_constant_u32(IV[6] ^ u32::MAX, layouter, self)?
    |                                                         ~~~

Check warning on line 566 in taiga_halo2/src/circuit/blake2s.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

usage of a legacy numeric method 

warning: usage of a legacy numeric method
   --> taiga_halo2/src/circuit/blake2s.rs:566:57
    |
566 |             Blake2sWord::from_constant_u32(IV[6] ^ u32::max_value(), layouter, self)?
    |                                                         ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    = note: `-W clippy::legacy-numeric-constants` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::legacy_numeric_constants)]`
help: use the associated constant instead
    |
566 |             Blake2sWord::from_constant_u32(IV[6] ^ u32::MAX, layouter, self)?
    |                                                         ~~~
View more details on GitHub Actions