Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy #261

Merged
merged 1 commit into from
Mar 23, 2024

fix clippy

15f6689
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix clippy #261

fix clippy
15f6689
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy (beta) succeeded Mar 23, 2024 in 0s

Clippy (beta)

33 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 33
Note 0
Help 0

Versions

  • rustc 1.78.0-beta.1 (efd9d2df1 2024-03-18)
  • cargo 1.78.0-beta.1 (2fe739fcf 2024-03-15)
  • clippy 0.1.78 (efd9d2d 2024-03-18)

Annotations

Check warning on line 55 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

empty doc comment

warning: empty doc comment
  --> taiga_halo2/src/taiga_api.rs:55:1
   |
55 | ///
   | ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `-W clippy::empty-docs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`

Check warning on line 55 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

empty doc comment

warning: empty doc comment
  --> taiga_halo2/src/taiga_api.rs:55:1
   |
55 | ///
   | ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `-W clippy::empty-docs` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::empty_docs)]`

Check warning on line 8 in taiga_halo2/src/vp_commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/vp_commitment.rs:8:5
  |
8 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 9 in taiga_halo2/src/transparent_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/transparent_ptx.rs:9:5
  |
9 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 19 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/transaction.rs:19:5
   |
19 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 234 in taiga_halo2/src/taiga_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `OsRng` is imported redundantly

warning: the item `OsRng` is imported redundantly
   --> taiga_halo2/src/taiga_api.rs:234:9
    |
232 |         taiga_api::*,
    |         ------------ the item `OsRng` is already imported here
233 |     };
234 |     use rand::rngs::OsRng;
    |         ^^^^^^^^^^^^^^^^^

Check warning on line 22 in taiga_halo2/src/shielded_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/shielded_ptx.rs:22:5
   |
22 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 28 in taiga_halo2/src/resource.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/resource.rs:28:5
   |
28 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 12 in taiga_halo2/src/proof.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/proof.rs:12:5
   |
12 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 16 in taiga_halo2/src/nullifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/nullifier.rs:16:5
   |
16 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 8 in taiga_halo2/src/vp_commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/vp_commitment.rs:8:5
  |
8 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 17 in taiga_halo2/src/merkle_tree.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/merkle_tree.rs:17:5
   |
17 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 9 in taiga_halo2/src/transparent_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
 --> taiga_halo2/src/transparent_ptx.rs:9:5
  |
9 | use serde;
  |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 12 in taiga_halo2/src/delta_commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/delta_commitment.rs:12:5
   |
12 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 19 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/transaction.rs:19:5
   |
19 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 22 in taiga_halo2/src/shielded_ptx.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/shielded_ptx.rs:22:5
   |
22 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 28 in taiga_halo2/src/resource.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/resource.rs:28:5
   |
28 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 12 in taiga_halo2/src/proof.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/proof.rs:12:5
   |
12 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 16 in taiga_halo2/src/nullifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/nullifier.rs:16:5
   |
16 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 17 in taiga_halo2/src/merkle_tree.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/merkle_tree.rs:17:5
   |
17 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 12 in taiga_halo2/src/delta_commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/delta_commitment.rs:12:5
   |
12 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 22 in taiga_halo2/src/compliance.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/compliance.rs:22:5
   |
22 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude

Check warning on line 248 in taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `RngCore` is imported redundantly

warning: the item `RngCore` is imported redundantly
   --> taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs:248:9
    |
239 |     use super::*;
    |         -------- the item `RngCore` is already imported here
...
248 |     use rand::RngCore;
    |         ^^^^^^^^^^^^^

Check warning on line 247 in taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `OsRng` is imported redundantly

warning: the item `OsRng` is imported redundantly
   --> taiga_halo2/src/circuit/vp_examples/partial_fulfillment_intent.rs:247:9
    |
239 |     use super::*;
    |         -------- the item `OsRng` is already imported here
...
247 |     use rand::rngs::OsRng;
    |         ^^^^^^^^^^^^^^^^^

Check warning on line 31 in taiga_halo2/src/circuit/vp_bytecode.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the item `serde` is imported redundantly

warning: the item `serde` is imported redundantly
  --> taiga_halo2/src/circuit/vp_bytecode.rs:31:5
   |
31 | use serde;
   |     ^^^^^ the item `serde` is already defined by prelude