fix anchor generation #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazzilic
reviewed
Oct 9, 2023
| @@ -381,6 +381,7 @@ pub fn generate_input_token_note_proving_info<R: RngCore>( | |||
| InputNoteProvingInfo::new( | |||
| input_note, | |||
| merkle_path, | |||
| None, | |||
There was a problem hiding this comment.
So if this is None, then it is calculated by the new constructor?
There was a problem hiding this comment.
Maybe the argument for anchor in the new method should be called custom_anchor, and if no custom anchor is provided then the standard one is calculated. Just to make it a bit easier to understand for the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal note anchor is generated from the path and note leaf, while the dummy(padding or intent) note anchor is from an existing valid root.