replace the sinsemillar note commitment with the poseidon commitment #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #199 and resolve #123 incidentally
note_cm = poseidon_hash(note, rcm)
.nf =Extract_P([PRF_{nk}(\rho) + \psi \ mod \ q] * K + note_cm)
tonf = poseidon_hash((nk || \rho || \psi || note_cm)
address = hash(app_data_dynamic || app_data_dynamic)
) in the note. Bothapp_data_dynamic
andnk_com
directly go to the note commitment.Potential improvement: There are seven field elements in Poseidon note commitment. If we composite the
is_merkle_checked
(bool) andvalue
(u64 but may be extended to u128 later) to one element(is_merkle_checked * (1<<128) + value
) in the circuit, we can save one round of Poseidon absorb. Is it worth it?