Remove reddsa from being a patch #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuyangSong
approved these changes
Aug 24, 2023
bazzilic
reviewed
Aug 24, 2023
taiga_halo2/Cargo.toml
Outdated
| @@ -15,7 +15,7 @@ halo2_proofs = {version="0.3", features = ["dev-graph"]} | |||
| bitvec = "1" | |||
| subtle = { version = "2.3", default-features = false } | |||
| dyn-clone = "1.0" | |||
| reddsa = "0.5" | |||
| reddsa = {version = "0.5", git = "https://github.com/heliaxdev/reddsa.git", branch = "taiga"} | |||
There was a problem hiding this comment.
I'm pretty sure if you do { git = ..., branch = ... }, then version = ... is ignored, as it just pulls the HEAD of the branch as the dependency.
There was a problem hiding this comment.
So we'd better remove the version =? It seems useless if we use the branch directly?
There was a problem hiding this comment.
Yes, I think so. Should be just
reddsa = { git = "https://github.com/heliaxdev/reddsa.git", branch = "taiga" }
There was a problem hiding this comment.
I'll open some more topics then, as some of the other dependencies have two specifications of what the revision should be
Patches change how inner packages compile, this makes it so that if anyone uses the project as a library they too have to include the dependency as a patch, since this dep can work as a dependnecy and not a patch, it is moved into a dep
mariari
force-pushed
the
mariari/remove-extra-patch
branch
from
522f4ad
to
6735991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches change how inner packages compile, this makes it so that if anyone uses the project as a library they too have to include the dependency as a patch, since this dep can work as a dependnecy and not a patch, it is moved into a dep