Minor fixups related to tests and features #433
Triggered via pull request
September 4, 2023 11:42
bazzilic
Status
Failure
Total duration
10m 22s
Artifacts
–
ci.yml
on: pull_request
Clippy lint checks
1m 58s
Nightly lint
1m 44s
Rustfmt
2m 33s
Security - Cargo Audit
7m 9s
Matrix: test
Annotations
10 errors and 44 warnings
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L424
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:424:28
|
424 | let borsh = tx.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L234
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:234:28
|
234 | self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L231
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:231:18
|
231 | .try_to_vec()
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L688
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:688:29
|
688 | let borsh = ocm.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L678
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:678:29
|
678 | let borsh = icm.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L669
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:669:37
|
669 | let borsh = output_note.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L660
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:660:36
|
660 | let borsh = input_note.try_to_vec().unwrap();
| ^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L234
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:234:28
|
234 | self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L231
error: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:231:18
|
231 | .try_to_vec()
| ^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
|
|
Clippy lint checks
Clippy had exited with the 101 exit code
|
|
use of `unwrap_or` to construct default value:
taiga_halo2/src/transaction.rs#L234
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:234:41
|
234 | self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
|
use of `unwrap_or` to construct default value:
taiga_halo2/src/transaction.rs#L232
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:232:18
|
232 | .unwrap_or(vec![])
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`
|
|
use of `unwrap_or` to construct default value:
taiga_halo2/src/transaction.rs#L234
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:234:41
|
234 | self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
|
use of `unwrap_or` to construct default value:
taiga_halo2/src/transaction.rs#L232
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:232:18
|
232 | .unwrap_or(vec![])
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L424
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:424:28
|
424 | let borsh = tx.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L234
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:234:28
|
234 | self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L231
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:231:18
|
231 | .try_to_vec()
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L688
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:688:29
|
688 | let borsh = ocm.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L678
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:678:29
|
678 | let borsh = icm.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L669
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:669:37
|
669 | let borsh = output_note.try_to_vec().unwrap();
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/note.rs#L660
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/note.rs:660:36
|
660 | let borsh = input_note.try_to_vec().unwrap();
| ^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L234
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:234:28
|
234 | self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^
|
|
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead:
taiga_halo2/src/transaction.rs#L231
warning: use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
--> taiga_halo2/src/transaction.rs:231:18
|
231 | .try_to_vec()
| ^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
Nightly lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Nightly lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy lint checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy lint checks
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rustfmt
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
|
|
Test on ubuntu-latest:
taiga_halo2/src/transaction.rs#L231
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest:
taiga_halo2/src/transaction.rs#L234
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest:
taiga_halo2/src/note.rs#L660
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest:
taiga_halo2/src/note.rs#L669
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest:
taiga_halo2/src/note.rs#L678
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest:
taiga_halo2/src/note.rs#L688
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest:
taiga_halo2/src/transaction.rs#L231
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest:
taiga_halo2/src/transaction.rs#L424
use of deprecated method `borsh::BorshSerialize::try_to_vec`: use `borsh::to_vec(&object)` instead
|
|
Test on ubuntu-latest
`taiga_halo2` (lib) generated 2 warnings
|