error: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq` --> taiga_halo2/src/lib.rs:3:9 | 3 | #![deny(clippy::derive_hash_xor_eq)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq` | = note: `-D renamed-and-removed-lints` implied by `-D warnings`

lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`: taiga_halo2/src/lib.rs#L3

Clippy lint checks

Clippy had exited with the 101 exit code

Test on ubuntu-latest

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

an array of `Range` that is only one element: taiga_halo2/src/transaction.rs#L330

warning: an array of `Range` that is only one element --> taiga_halo2/src/transaction.rs:330:9 | 330 | [0..num].iter().for_each(|_| { | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init = note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all` help: if you wanted a `Vec` that contains the entire range, try | 330 | (0..num).collect::<std::vec::Vec<usize>>().iter().for_each(|_| { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

useless use of `vec!`: taiga_halo2/src/shielded_ptx.rs#L355

warning: useless use of `vec!` --> taiga_halo2/src/shielded_ptx.rs:355:37 | 355 | let app_dynamic_vp_vk = vec![compressed_trivial_vp_vk, compressed_trivial_vp_vk]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[compressed_trivial_vp_vk, compressed_trivial_vp_vk]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `-W clippy::useless-vec` implied by `-W clippy::all`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: taiga_halo2/src/shielded_ptx.rs#L66

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> taiga_halo2/src/shielded_ptx.rs:66:18 | 66 | .zip(output_info.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `output_info` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

it looks like you're trying to convert a tuple to an array: taiga_halo2/src/circuit/merkle_circuit.rs#L97

warning: it looks like you're trying to convert a tuple to an array --> taiga_halo2/src/circuit/merkle_circuit.rs:97:32 | 97 | let poseidon_message = [pair.0, pair.1]; | ^^^^^^^^^^^^^^^^ | = help: use `.into()` instead, or `<[T; N]>::from` if type annotations are needed = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tuple_array_conversions

it looks like you're trying to convert a tuple to an array: taiga_halo2/src/circuit/integrity.rs#L375

warning: it looks like you're trying to convert a tuple to an array --> taiga_halo2/src/circuit/integrity.rs:375:63 | 375 | poseidon_to_curve::<POSEIDON_TO_CURVE_INPUT_LEN>(&[vk, data]).to_affine() | ^^^^^^^^^^ | = help: use `.into()` instead, or `<[T; N]>::from` if type annotations are needed = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tuple_array_conversions = note: `-W clippy::tuple-array-conversions` implied by `-W clippy::all`

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: taiga_halo2/src/circuit/gadgets/target_note_variable.rs#L194

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> taiga_halo2/src/circuit/gadgets/target_note_variable.rs:194:18 | 194 | .zip(self.note_variable_pairs.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.note_variable_pairs` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: taiga_halo2/src/circuit/gadgets/target_note_variable.rs#L113

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> taiga_halo2/src/circuit/gadgets/target_note_variable.rs:113:21 | 113 | / nf_or_cm_minus_owned_note_pub_id_is_zero_vec 114 | | .clone() 115 | | .into_iter(), | |____________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 113 ~ nf_or_cm_minus_owned_note_pub_id_is_zero_vec 114 ~ .clone(), |

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: taiga_halo2/src/circuit/gadgets/target_note_variable.rs#L105

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> taiga_halo2/src/circuit/gadgets/target_note_variable.rs:105:26 | 105 | .zip(inv_vec.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_vec` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/core/src/iter/traits/iterator.rs:641:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`