Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of low hanging fruit masp tests (backport #3921) #3923

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

Describe your changes

Increases the test coverage report in the affected files.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #3921 done by [Mergify](https://mergify.com).

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 16, 2024
@mergify mergify bot merged commit 2e67d81 into 0.44.0 Oct 16, 2024
20 of 21 checks passed
@mergify mergify bot deleted the mergify/bp/0.44.0/pr-3921 branch October 16, 2024 09:13
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 99.58848% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (1a8ca52) to head (e2b4450).
Report is 2 commits behind head on 0.44.0.

Files with missing lines Patch % Lines
crates/core/src/masp.rs 99.58% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           0.44.0    #3923      +/-   ##
==========================================
+ Coverage   73.26%   73.39%   +0.13%     
==========================================
  Files         341      341              
  Lines      105334   105576     +242     
==========================================
+ Hits        77168    77487     +319     
+ Misses      28166    28089      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants