feat: Add new rpc query function to check validators' liveness(uptime) #3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3899 +/- ##
==========================================
- Coverage 73.04% 73.00% -0.04%
==========================================
Files 340 340
Lines 104816 104856 +40
==========================================
- Hits 76559 76554 -5
- Misses 28257 28302 +45 ☔ View full report in Codecov by Sentry. |
Jeongseup
commented
Oct 8, 2024
|
@brentstone Thank you for checking my PR and improve the codes. I've learned rust from you 🙏 |
brentstone
force-pushed
the
jeongseup/feature/get-validators-livenesses
branch
from
5266d30
to
bdf352e
Compare
tzemanovic
reviewed
Oct 10, 2024
tzemanovic
reviewed
Oct 11, 2024
crates/sdk/src/queries/vp/pos.rs
Outdated
| read_consensus_validator_set_addresses(ctx.state, epoch)?; | ||
| let params = read_pos_params::<_, governance::Store<_>>(ctx.state)?; | ||
|
|
||
| let mut result = vec![]; |
There was a problem hiding this comment.
one more small thing, now that the size of this vec is same as consensus_validators.len() we can allocate it to its size
tzemanovic
reviewed
Oct 11, 2024
tzemanovic
approved these changes
Oct 11, 2024
tzemanovic
added
merge
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
(cherry picked from commit bdf352e)
Merged
3 tasks
mergify bot
added a commit
that referenced
this pull request
Oct 11, 2024
feat: Add new rpc query function to check validators' liveness(uptime) (backport #3899)
tzemanovic
added a commit
that referenced
this pull request
Oct 11, 2024
* 0.44.0: Namada 0.44.1 Removes old reference to encrypted txs test/e2e/ibc: try to kill gaiad before running it Fixes broken assertions in integration tests Update crates/sdk/src/queries/vp/pos.rs small fix from comments changelog: add #3899 fix up liveness queries Add new rpc query function to check validators' liveness(uptime) in this epoch test/e2e: try to forward Ctrl+C to the bg session Changelog for #3860 feat: serde rename batch index into masp tx index Tries to drop bg process in tests mergify: unquote base branch name Changelog #3882 Extends batch sections test to check duplicate sections Custom `PartialEq` impl for `SigningTxData` Fixes cmt reference in `add_inner_tx` Avoids duplicated sections when contructing a batch ci/mergify: unquote base name Increases timeout on epoch sleep Improves epoch sleeping in ibc tests and renames token variable Changelog #3866 Sped up ibc token test Fixes ibc gas payment test Fixes typos and updates docstring e2e test for ibc token gas payment goveranance: let validator vote even if it doesn't have a self-bond changelog: add #3835 tx: test tx sections api tx: improve the serialization api test/tx: add more unit tests tx: split out tx sections into dedicated mod tx: move signing related code into sign mod tx: rm unsued `SignedTxData` refactor and test signature index tx/types: rm unused code test/e2e: no dbg logs in shielded sync ci/mergify: add merge rule for backport to 0.44 mergify: add backport strategy Changelog #3857 Removes unused `Success` event Adds test for identical events in batch Adds batch events tests Removes eprintln from prepare proposal unit tests Adds tests for whitelisted tokens gas payment update hermes test/e2e: increase hermes timeout README: add notes about hermes update hermes ci: run checks on release branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Hello, I'm Jeongseup from Cosmostation. I hope the Namada mainnet genesis launch is successful.
I believe it would be beneficial for each validator to monitor their own liveness(uptime) status during the current epoch to prevent slashsing or other penalties.
Therefore, I have implemented a new RPC query function that retrieves the liveness status of validators who are active in this epoch.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo