Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serde rename batch index into masp tx index #3860

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mateuszjasiuk
Copy link
Contributor

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 added bug Something isn't working client SDK cli and removed cli labels Oct 1, 2024
sug0 added a commit that referenced this pull request Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (7ac415a) to head (b2bdee6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3860   +/-   ##
=======================================
  Coverage   73.24%   73.24%           
=======================================
  Files         341      341           
  Lines      105240   105240           
=======================================
+ Hits        77085    77088    +3     
+ Misses      28155    28152    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 4, 2024
mergify bot added a commit that referenced this pull request Oct 4, 2024
Copy link
Contributor

mergify bot commented Oct 4, 2024

Hey @mateuszjasiuk, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Oct 4, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Oct 4, 2024
Copy link
Contributor

mergify bot commented Oct 4, 2024

Hey @mateuszjasiuk, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

it looks like this a breaking change for IBC (possibly in hermes) as it keeps failing in ibc_upgrade_client

@sug0
Copy link
Contributor

sug0 commented Oct 7, 2024

@tzemanovic hm that's odd. I'm not sure if that issue is specific to this PR, since ibc upgrade client doesn't have anything to do with the masp

@brentstone
Copy link
Collaborator

Whats the status here? I'd like to cut 0.45.0 very soon, and my latest understanding is that this should be included. @Fraccaman

@tzemanovic tzemanovic force-pushed the mateusz/serde-rename-batch-index branch from 4093f0b to b2bdee6 Compare October 10, 2024 10:00
@mergify mergify bot merged commit 514f581 into main Oct 10, 2024
22 checks passed
@mergify mergify bot deleted the mateusz/serde-rename-batch-index branch October 10, 2024 10:33
mergify bot pushed a commit that referenced this pull request Oct 10, 2024
(cherry picked from commit b2bdee6)
mergify bot added a commit that referenced this pull request Oct 11, 2024
feat: serde rename batch index into masp tx index (backport #3860)
tzemanovic added a commit that referenced this pull request Oct 11, 2024
* 0.44.0:
  Namada 0.44.1
  Removes old reference to encrypted txs
  test/e2e/ibc: try to kill gaiad before running it
  Fixes broken assertions in integration tests
  Update crates/sdk/src/queries/vp/pos.rs
  small fix from comments
  changelog: add #3899
  fix up liveness queries
  Add new rpc query function to check validators' liveness(uptime) in this epoch
  test/e2e: try to forward Ctrl+C to the bg session
  Changelog for #3860
  feat: serde rename batch index into masp tx index
  Tries to drop bg process in tests
  mergify: unquote base branch name
  Changelog #3882
  Extends batch sections test to check duplicate sections
  Custom `PartialEq` impl for `SigningTxData`
  Fixes cmt reference in `add_inner_tx`
  Avoids duplicated sections when contructing a batch
  ci/mergify: unquote base name
  Increases timeout on epoch sleep
  Improves epoch sleeping in ibc tests and renames token variable
  Changelog #3866
  Sped up ibc token test
  Fixes ibc gas payment test
  Fixes typos and updates docstring
  e2e test for ibc token gas payment
  goveranance: let validator vote even if it doesn't have a self-bond
  changelog: add #3835
  tx: test tx sections api
  tx: improve the serialization api
  test/tx: add more unit tests
  tx: split out tx sections into dedicated mod
  tx: move signing related code into sign mod
  tx: rm unsued `SignedTxData`
  refactor and test signature index
  tx/types: rm unused code
  test/e2e: no dbg logs in shielded sync
  ci/mergify: add merge rule for backport to 0.44
  mergify: add backport strategy
  Changelog #3857
  Removes unused `Success` event
  Adds test for identical events in batch
  Adds batch events tests
  Removes eprintln from prepare proposal unit tests
  Adds tests for whitelisted tokens gas payment
  update hermes
  test/e2e: increase hermes timeout
  README: add notes about hermes
  update hermes
  ci: run checks on release branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-44 bug Something isn't working client merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants