Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/generalize vectorized transfers #3446

Closed
wants to merge 17 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Jun 27, 2024

Describe your changes

Attempt to simplify the combination of split MASP transfers and vectorized transfers. The main change is to make a transfer format that allows shielded operations to be done in the presence of both transparent inputs and transparent outputs. All the other transfer formats are then subsumed into this one.

Indicate on which release or other PRs this topic is based on

#3356

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@murisi murisi force-pushed the murisi/generalize-vectorized-transfers branch from d15774f to 29a64eb Compare June 27, 2024 17:07
@murisi murisi requested a review from cwgoes June 27, 2024 17:08
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0.38119% with 784 lines in your changes missing coverage. Please review.

Project coverage is 53.88%. Comparing base (879a326) to head (6110726).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/sdk/src/tx.rs 0.00% 281 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 217 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 88 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 68 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 41 Missing ⚠️
crates/light_sdk/src/transaction/transfer.rs 0.00% 26 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 24 Missing ⚠️
crates/apps_lib/src/client/tx.rs 0.00% 16 Missing ⚠️
crates/token/src/lib.rs 0.00% 15 Missing ⚠️
crates/encoding_spec/src/main.rs 0.00% 5 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
- Coverage   53.92%   53.88%   -0.05%     
==========================================
  Files         317      317              
  Lines      107575   107645      +70     
==========================================
- Hits        58011    58005       -6     
- Misses      49564    49640      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi mentioned this pull request Jun 28, 2024
2 tasks
@brentstone brentstone mentioned this pull request Jun 28, 2024
@murisi murisi requested review from grarco and tzemanovic June 28, 2024 16:24
cwgoes
cwgoes previously approved these changes Jun 28, 2024
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptual ACK - much, much cleaner!

@brentstone brentstone marked this pull request as ready for review June 28, 2024 18:38
crates/sdk/src/args.rs Outdated Show resolved Hide resolved
token,
amount,
} in data
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: I think I've improved this in #3393 by trying to group the same sources/tokens before looking for the available notes

grarco
grarco previously approved these changes Jul 1, 2024
crates/token/src/lib.rs Outdated Show resolved Hide resolved
tzemanovic
tzemanovic previously approved these changes Jul 1, 2024
@murisi murisi dismissed stale reviews from tzemanovic and grarco via 6436e48 July 1, 2024 15:18
@murisi murisi force-pushed the murisi/generalize-vectorized-transfers branch from 6436e48 to 6110726 Compare July 1, 2024 15:35
@brentstone
Copy link
Collaborator

Closing in favor of #3459

@brentstone brentstone closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants