Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect wasm-dir on init-network #3432

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Jun 21, 2024

Describe your changes

Close #3299

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.91%. Comparing base (5cc23b4) to head (dd4506e).

Files Patch % Lines
crates/apps_lib/src/client/utils.rs 0.00% 6 Missing ⚠️
crates/apps_lib/src/cli/client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3432      +/-   ##
==========================================
- Coverage   53.92%   53.91%   -0.01%     
==========================================
  Files         317      317              
  Lines      107575   107578       +3     
==========================================
- Hits        58007    58005       -2     
- Misses      49568    49573       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic
tzemanovic previously approved these changes Jun 24, 2024
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just needs a changelog)

@brentstone brentstone mentioned this pull request Jun 28, 2024
@brentstone brentstone changed the title respect warm-dir on init-network respect wasm-dir on init-network Jun 28, 2024
brentstone added a commit that referenced this pull request Jul 3, 2024
* fraccaman/respect-wasm-dir:
  added changelog
  respect warm-dir on init-network
brentstone added a commit that referenced this pull request Jul 4, 2024
* origin/fraccaman/respect-wasm-dir:
  added changelog
  respect warm-dir on init-network
@brentstone brentstone merged commit 71ce06f into main Jul 5, 2024
18 of 19 checks passed
@brentstone brentstone deleted the fraccaman/respect-wasm-dir branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag --wasm-dir on command namadac utils init-network has no effect
3 participants