Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use generic proof record type #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heueristik
Copy link
Collaborator

@heueristik heueristik commented Oct 16, 2024

@paulcadman can you review and see if this makes sense? Should we use the generic proof record type here as we are doing it already within the Action record?

type Action :=
mkAction {
commitments : Set Resource.Commitment;
nullifiers : Set Resource.Nullifier;
proofRecords : Set ProofRecord;
appData : AppData
};

Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we discussed this at some point but I can't remember the conclusion.

Q: Should the Delta prove function use the generic proof type. It's using Parametrized.GenericProofRecord which I thought we had removed. There seems to be some inconsistency in the types between how delta proofs are computed and how they're stored in the transaction.

prove
(provingKey : Delta.ProvingKey)
(publicInputs : Delta.Instance)
(privateInputs : Delta.Witness)
: Delta.Proof := MISSING_ANOMA_BUILTIN;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants