-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test #4
base: master
Are you sure you want to change the base?
test #4
Conversation
@@ -0,0 +1,135 @@ | |||
# Grid layout(Tizen 6.0 or late) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space between word "layout" and the first parenthesis.
Also, replace the word "late" with "later".
@@ -0,0 +1,135 @@ | |||
# Grid layout(Tizen 6.0 or late) | |||
|
|||
> **Note** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the note format to the latest as below:
[!Note]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari Correct form is:
Note
Text
This means you need to ask to remove > in middle.
And, The note is all caps
|
||
> **Note** | ||
> | ||
> If you are using GridLayout on Tizen 5.5, Please refer to [Grid Layout(Tizen 5.5)](#gridlayout-tizen5.5) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change first letter to lower case in the word "Please".
> | ||
> If you are using GridLayout on Tizen 5.5, Please refer to [Grid Layout(Tizen 5.5)](#gridlayout-tizen5.5) instead. | ||
|
||
`GridLayout` is a grid box for the two dimentional layout. It constraints the x and y position, width and height of the child actors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error : change "dimentional" to "dimensional".
Also, please change the second sentence as below:
It constraints the x and y positions, width, and height of the child actors.
|
||
Positioning children in a grid form, the size of each column and row is set to the largest size of cells belonging to their axis. | ||
|
||
If the `Column` or the `row` Property is not specified on the child, it is automtically assigned left to right or top to bottom depends on the `GridOrientation` Property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change first letter to upper case in the word "row". Also, change first letter to lower case in the word "Property" at both the places in the sentence.
Spelling error : change "automtically" as "automatically"
Can we phrase the sentence as below?
If the Column
or Row
property is not specified on the child, GridLayout
automatically assigns left to right or top to bottom, depending on the GridOrientation
property.
![gridAlignment](./media/gridAlignment.png) | ||
|
||
<a name="gridlayout-tizen5.5"></a> | ||
# Grid Layout(Tizen 55) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add space between word "Layout" and the first parenthesis.
Also, change Tizen 55 as Tizen 5.5
|
||
`GridLayout` is a grid box for the two dimentional layout. It constraints the x and y position, width and height of the child actors. | ||
|
||
Positioning children in a grid form, the size of each column and row is set to the largest size of cells belonging to their axis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the condition and sentence as below?
To position children in a grid form, set the size of each column and row to the largest size of cells belonging to their axis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GridLayout
is a grid box for the two-dimensional layout. It constraints the x and y position, width and height of the child actors. GridLayout
positions the children in a grid form, where the size of each column and row is set to the largest size of the cells belonging to their axis.
If the `Column` or the `row` Property is not specified on the child, it is automtically assigned left to right or top to bottom depends on the `GridOrientation` Property. | ||
|
||
|
||
There are two types of properties. One is the properties for the grid layout and Another one is the properties that affect the specified child: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace "Another one" with "the other" in the sentence.
Also change grid layout to GridLayout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the ist sentence is incomplete, we can write:
There are two types of properties that affect the GridLayout
. One is the properties for the grid layout and the other is the properties that affect the specified child.
The following table describes the properties of `GridLayout`. | ||
| Property | Type | Description | | ||
| -----------------------| --------------- | ------------ | | ||
| `Columns` | int | Gets or sets the number of colomns in the grid. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spell Error : Change "colomns" to "columns"
| `ColumnSpacing | `float` | Gets or sets the distance between columns | | ||
| `RowSpacing` | float | Gets or sets the distance between rows. | | ||
|
||
<a name="columns-and-rows"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this line has been added?
|
||
When the `Column` or the `Row` of child is automatically set without specified value, the value cannot be exceeded the number of main-axis cell which is the `Columns` value on horizontal orientation or the `Rows` value on vertical orientation. But, it can be assigned a value that exceeds the number of cross-axis cell. | ||
|
||
The following figures shows how to set the `Colomns` and the `Rows` properties. Since the `GridOrientation` is set to horizontal, the row index of last item can be `2` that exceeds the `Rows` property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "figures" to figure, since there is only one figure included.
Spell error : Change Colomns
to Columns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following figures shows how to set the `Colomns` and the `Rows` properties. Since the `GridOrientation` is set to horizontal, the row index of last item can be `2` that exceeds the `Rows` property. | |
The following figure shows how to set the `Columns` and the `Rows` properties. Since the `GridOrientation` is set to horizontal, the row index of the last item can be `2` that exceeds the `Rows` property: |
Point to be noted:
Whenever the sentence is followed up by an image, table or code segment we use a colon instead of a period.
|
||
The `Columns` and the `Rows` properties specify the maximum number of cells on a horizontal or vertical axis. | ||
|
||
When the `Column` or the `Row` of child is automatically set without specified value, the value cannot be exceeded the number of main-axis cell which is the `Columns` value on horizontal orientation or the `Rows` value on vertical orientation. But, it can be assigned a value that exceeds the number of cross-axis cell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update sentence as below:
When the Column
or the Row
of child is automatically set without specified value, the value cannot exceed the number of main-axis cell which is (rest is fine in the sentence)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But doesn't go well in the sentence , so consider changing it.
However, ....it can be assigned a value that exceeds the number of cross-axis cell.
|
||
The following figures shows how to set the `Colomns` and the `Rows` properties. Since the `GridOrientation` is set to horizontal, the row index of last item can be `2` that exceeds the `Rows` property. | ||
|
||
![Column](./media/columnLayout.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update file name inside the square bracket to [columnLayout]
gridLayout.Rows = 1 | ||
layoutView.Layout = gridLayout; | ||
``` | ||
<a name="grid-orientation"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this line has been added?
``` | ||
<a name="grid-orientation"></a> | ||
## Grid Orientation | ||
The `GridOrientation` only works when a child is added without the specified `Row` or `Column` property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Can we change the sentence as below:
The GridOrientation
only works when a child is added without specifying the Row
or Column
property.
OR
The GridOrientation
only works when a child is added without the specific Row
or Column
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari
If you are in doubt, it's better to ask the developer to elaborate things.
After you understand, then you can give your suggestion. And whenever you give a suggestion/rephrase ensure you don't change the meaning.
|
||
The following figure shows how the `GridOrientation` property works: | ||
|
||
![gridOrientation](./media/gridOrientatio.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the last letter in the file name.
./media/gridOrientation.png
<a name="grid-orientation"></a> | ||
## Grid Orientation | ||
The `GridOrientation` only works when a child is added without the specified `Row` or `Column` property. | ||
- On horizontal orientation, the children will autmatically occupy empty cells from left to right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spell error :
Change "autmatically" as "automatically"
Also, please add article "the" before word "empty".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari We dont use will in our docs, where ever you find future tense, change it to present or present perfect tense.
## Grid Orientation | ||
The `GridOrientation` only works when a child is added without the specified `Row` or `Column` property. | ||
- On horizontal orientation, the children will autmatically occupy empty cells from left to right. | ||
- On vertical orientation, the children will automatically occupy empty cells from top to bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add article "the" before word "empty".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari We dont use will in our docs, where ever you find future tense, change it to present or present perfect tense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On horizontal orientation, the children automatically occupy the empty cells from left to right.
|
||
## Column spacing and row spacing | ||
|
||
The `ColumnSpacing` and `rowSpacing` properties are the distance between columns or rows. In order to set same sapce between the children, you can use `ColumnSpacing` and `rowSpacing` properties instead of setting the same margin for each child. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change rowSpacing
to RowSpacing
Change "distance" to "distances"
Spell error: Change "sapce" to "space". Also add article "the" before word same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `ColumnSpacing` and `rowSpacing` properties are the distance between columns or rows. In order to set same sapce between the children, you can use `ColumnSpacing` and `rowSpacing` properties instead of setting the same margin for each child. | |
The `ColumnSpacing` and `rowSpacing` properties are the distance between columns or rows. In order to set the same space between the children, you can use `ColumnSpacing` and `rowSpacing` properties instead of setting the same margin for each child. |
What made you change the property name, did you refer to something ? Or you thought r must be capital. Property names must be written as is in the code, if you don't know about the property name base page ask the developer to guide you to reach the API/ class names.
Precisely ColumnSpacing
and rowSpacing
are property names. These must be written as per their usage in code or API files.
In line 56 r is small, and in 58 r is capital. So ask developer what is correct way.
|
||
## Column and row | ||
|
||
The `Column` and `row` properties specify the cell index of the child. If these properties aren't assigned, they are automaticaly set dependig on [`GridOrientation`](#grid-orientation), [`Columns`](#columns-and-rows) and [`Rows`](#columns-and-rows). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plse change row
to Row
Also, please write the word completely : "aren't" as "are not"
Spell error : change "dependig" as "depending"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Missed automatically spell.
- Serial comma missing before and.
You must not change property name without referencing its code or API usage, row
is correct until you check n verify Row
is used. No guesswork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check here:https://samsung.github.io/TizenFX/API9/api/Tizen.NUI.GridLayout.html#properties
Please use these parameter names from the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As both Columns and Rows are going to the same location, #columns-and-rows,
how about changing it to below?
Columns
and Rows
|
||
## Column span and row span | ||
|
||
The `ColumnSpan` and `rowSpan` properties the number of cell that the child occupy. The sum of cell index and cell span should be less than maximun number of cell specified by `Columns` or `Rows` Properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plse change rowSpan
to RowSpan
Plse update first sentence as below:
The ColumnSpan
and RowSpan
properties specify the number of cell that the child occupy.
Also, add word "the" before word "maximum".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `ColumnSpan` and `rowSpan` properties the number of cell that the child occupy. The sum of cell index and cell span should be less than maximun number of cell specified by `Columns` or `Rows` Properties. | |
The `ColumnSpan` and `rowSpan` properties the number of cells that the child occupies. The sum of cell index and cell span should be less than the maximum number of the cell specified by `Columns` or `Rows` Properties. |
Missed spell maximum.
|
||
## Horizontal stretch and vertical stretch | ||
|
||
The `HorizontalStretch` and `VerticalStretch` properties define how child is resized within space of the cell. the value can be `Stretchflags` enum: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last sentence looks incomplete. Can you please check and update?
Also, there is no reference to image in the topic. Please check and add the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `HorizontalStretch` and `VerticalStretch` properties define how child is resized within space of the cell. the value can be `Stretchflags` enum: | |
The `HorizontalStretch` and `VerticalStretch` properties define how the child is resized within the space of the cell. The values can be specified as `Stretchflags` enum: |
|
||
## Horizontal alignment and vertical alignment | ||
|
||
The `HorizontalAlignment` and `VerticalAlignment` properties specify the alignment for the child within its cells: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace colon (:) with period (.) at the end of the sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari Here we use : . Whenever there is code, image or table which immediately follows up a sentence we use :.
|
||
The `HorizontalAlignment` and `VerticalAlignment` properties specify the alignment for the child within its cells: | ||
|
||
![gridAlignment](./media/gridAlignment.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reference to this image in the topic. Please check for missing content and include the same.
|
||
![gridAlignment](./media/gridAlignment.png) | ||
|
||
<a name="gridlayout-tizen5.5"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this has been added?
|
||
`GridLayout` is a grid box for the two dimensional layout. It constraints the x and y position, width, and height of the child actors. | ||
|
||
Positioning children in a grid form, the cells are of uniform size based on the first child added to the parent View. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence doesn't look phrased properly, not sure what we are trying to convey here? could you please check and update?
Positioning children in a grid form, the cells are of uniform size based on the first child added to the parent View. | ||
|
||
You can set the number of **columns**, however the rows automatically increase to hold the children. After the available space is used, the remaining rows become invisible by default. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a reference to below table for consistency?
|
||
You can set the number of **columns**, however the rows automatically increase to hold the children. After the available space is used, the remaining rows become invisible by default. | ||
|
||
| Property | Type | Descrption | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spell error : change "Descrption" as "Description"
|
||
## Colomn | ||
|
||
![Column](./media/columnLayout.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update file name inside the square bracket as [columnLayout]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Annie, kindly check and let me know if you find any issues in my comments provided? Also, let me know if I have missed any check points while reviewing this PR?
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari Please check my comments.
|
||
When the `Column` or the `Row` of child is automatically set without specified value, the value cannot be exceeded the number of main-axis cell which is the `Columns` value on horizontal orientation or the `Rows` value on vertical orientation. But, it can be assigned a value that exceeds the number of cross-axis cell. | ||
|
||
The following figures shows how to set the `Colomns` and the `Rows` properties. Since the `GridOrientation` is set to horizontal, the row index of last item can be `2` that exceeds the `Rows` property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following figures shows how to set the `Colomns` and the `Rows` properties. Since the `GridOrientation` is set to horizontal, the row index of last item can be `2` that exceeds the `Rows` property. | |
The following figure shows how to set the `Columns` and the `Rows` properties. Since the `GridOrientation` is set to horizontal, the row index of the last item can be `2` that exceeds the `Rows` property: |
Point to be noted:
Whenever the sentence is followed up by an image, table or code segment we use a colon instead of a period.
``` | ||
<a name="grid-orientation"></a> | ||
## Grid Orientation | ||
The `GridOrientation` only works when a child is added without the specified `Row` or `Column` property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari
If you are in doubt, it's better to ask the developer to elaborate things.
After you understand, then you can give your suggestion. And whenever you give a suggestion/rephrase ensure you don't change the meaning.
| `RowSpacing` | float | Gets or sets the distance between rows. | | ||
|
||
<a name="columns-and-rows"></a> | ||
## Columns and rows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari We follow sentence case, so you can write like this:
Global: Use sentence case for all headings. For reference : https://github.com/Samsung/tizen-docs/blob/master/styleguide/style.md
<a name="grid-orientation"></a> | ||
## Grid Orientation | ||
The `GridOrientation` only works when a child is added without the specified `Row` or `Column` property. | ||
- On horizontal orientation, the children will autmatically occupy empty cells from left to right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari We dont use will in our docs, where ever you find future tense, change it to present or present perfect tense.
## Grid Orientation | ||
The `GridOrientation` only works when a child is added without the specified `Row` or `Column` property. | ||
- On horizontal orientation, the children will autmatically occupy empty cells from left to right. | ||
- On vertical orientation, the children will automatically occupy empty cells from top to bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarkedari We dont use will in our docs, where ever you find future tense, change it to present or present perfect tense.
## Grid Orientation | ||
The `GridOrientation` only works when a child is added without the specified `Row` or `Column` property. | ||
- On horizontal orientation, the children will autmatically occupy empty cells from left to right. | ||
- On vertical orientation, the children will automatically occupy empty cells from top to bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On horizontal orientation, the children automatically occupy the empty cells from left to right.
|
||
## Column and row | ||
|
||
The `Column` and `row` properties specify the cell index of the child. If these properties aren't assigned, they are automaticaly set dependig on [`GridOrientation`](#grid-orientation), [`Columns`](#columns-and-rows) and [`Rows`](#columns-and-rows). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check here:https://samsung.github.io/TizenFX/API9/api/Tizen.NUI.GridLayout.html#properties
Please use these parameter names from the API
|
||
## Column and row | ||
|
||
The `Column` and `row` properties specify the cell index of the child. If these properties aren't assigned, they are automaticaly set dependig on [`GridOrientation`](#grid-orientation), [`Columns`](#columns-and-rows) and [`Rows`](#columns-and-rows). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As both Columns and Rows are going to the same location, #columns-and-rows,
how about changing it to below?
Columns
and Rows
| `Columns` | int | Gets or sets the number of columns in the grid. | | ||
|
||
|
||
## Colomn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Column
## Related Information | ||
|
||
* Dependencies | ||
* Tizen 5.5 and Higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Related Information | |
* Dependencies | |
* Tizen 5.5 and Higher | |
## Related Information | |
- Dependencies | |
- Tizen 5.5 and Higher |
We always use - instead of * or +
Test file