Changed the JQuery detection #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngular and not just loaded as a global lib
|
@dhilt Hello Denis - Are you willing to merge these pull requests or do you have any concern with them? |
|
@priandsf Sorry, I haven't been here for 1 week...
|
|
@dhilt Not a problem - I'll be out soon as well :-) |
|
@priandsf I cherry-picked your commit and released angular-ui-scroll v1.7.4 with only jqLite/jQuery stuff. Could you please check if it does work for you? And let's continue optimization things in #221. |
|
Thanks @dhilt I tested it and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application, we need to force Angular to use jqLite while jQuery is loaded. The current detection mechanism is checking if jQuery is loaded, but not if it is actually used.
This pull request is checking if
Angular.elementis effectively jQuery by checking ifangular.element.fn.jqueryis defined, meaning that jQuery is the library used by Angular.