This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Fix for #205 #206
Open
Fix for #205 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could anyone check this pull request and merge if you can? |
|
Hi @SomeKittens - Could you please help to merge this pull request? It fixes splitter far left drag issue leading to "Cannot read property0 of undefined". Appreciate your help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that mouseMoveHandler was not correctly handling mouse positions of 0, treating it as falsy and falling back on other event properties. The fall-through case was also unhandled, resulting in an undefined exception.
Added new getMousePosition function to the controller so it could be individually unit tested and updated it to check for existence of mousePosition properties. If getMousePosition fails to find a valid position on the event it will return null and mouseMoveHandler will not requestAnimationFrame.