Fix for Apple Silicon #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suleymanbilgin
approved these changes
Jan 24, 2024
vlaci
added a commit
to vlaci/nixpkgs
that referenced
this pull request
Oct 1, 2024
Based on upstream PR: anestisb/android-simg2img#38 This fixes broken tests of Unblob as well
vlaci
added a commit
to vlaci/nixpkgs
that referenced
this pull request
Oct 1, 2024
Based on upstream PR: anestisb/android-simg2img#38 This fixes broken tests of Unblob as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as was previously accepted in pull request #15, and subsequently lost when "output_file.c" was replaced with "output_file.cpp."
simg2img does not work on Apple Silicon-based Macs, failing with an error "Cannot write output file." This is because simg2img makes a call to mmap64 with an offset of 4096 (the page size on x86-based systems). mmap64 requires that the offset be a multiple of the page size, and the page size on Apple Silicon is 16384; therefore, the mmap64 call fails.
This change calculates the appropriate offset using the actual page size of the system rather than a hardcoded 4096.