Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add styles for dialog element & its backdrop #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krypton225
Copy link

Description

This PR implements new styles to address an issue with heading elements inside the dialog HTML element.

The goal is to:

  • Ensure there is a beautiful design for the dialog HTML element.
  • Make additional styles for dialog header, content, and footer to improve the overall UI and UX.

Changes Made

  • Add new styles for the dialog HTML element using some custom CSS properties in the mvp.css file.
  • Add a style for the ::backdrop pseudo-element to make sense for the user with some background-color and opacity.
  • Add a new section in the index.html file to make an example for the dialog and its state in the open.

Screenshot

image

Additional Notes

  • If there are any specific design guidelines or additional functionality to consider, please let me know.
  • Feel free to reach out if you have any questions or need further clarification on the changes.

@ChristopherBilg
Copy link
Collaborator

Hey Krypton! I'm more than happy to review this and potentially add some of it; however, MVP.css is designed and intended to be an Out of the box CSS styling for HTML elements. No class names, no framework to learn. I see the majority of your proposed changes are in class names. If you'd like to refactor those into CSS combinators (and the like), then I would be happy to include these changes.

@krypton225
Copy link
Author

@ChristopherBilg

Thank you very much!
I'm happy to read your awesome comment.

OK. As you said: MVP.css is designed and intended to be an Out-of-the-box CSS styling for HTML elements. No class names, no framework to learn..

Do you need to remove the classes only, with the example of course, and push a new commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants