Update AGP, Upgrade Gradle, Fix Override Library, Fix DnD samples on SDK 21 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrezgui
requested changes
Aug 29, 2024
secondsun
force-pushed
the
minsdk_upates_and_fixes
branch
2 times, most recently
from
6dc26fd
to
c12e926
Compare
updating gradle updating AGP DragAndDropRichContentReceiverFragment is marked as requiresApi 31
secondsun
force-pushed
the
minsdk_upates_and_fixes
branch
from
c12e926
to
5b9be33
Compare
|
@yrezgui I've reverted the minSDK update and fixed the build. Turns out AGP changed behavior and the problem was in our manifest. Please re-review. |
yrezgui
approved these changes
Sep 4, 2024
secondsun
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating minSDK to 24
updating gradle
updating AGP
removing overidesLibrary
DragAndDropRichContentReceiverFragment is marked as requiresApi 31