Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing allowNotifications() in BaselineProfileGenerator.kt #858

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Add missing allowNotifications() in BaselineProfileGenerator.kt #858

merged 4 commits into from
Aug 22, 2023

Conversation

SimonMarquis
Copy link
Contributor

@SimonMarquis SimonMarquis commented Jul 25, 2023 •
edited
Loading

And add a small delay before fling gesture.

Closes #853

Test: gradlew benchmarks:connectedDemoBenchmarkAndroidTest

@SimonMarquis SimonMarquis mentioned this pull request Jul 26, 2023
Closed
3 tasks
@mmoczkowski mmoczkowski self-requested a review August 22, 2023 08:55
mmoczkowski
mmoczkowski approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mmoczkowski mmoczkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmoczkowski mmoczkowski merged commit d2d12b9 into android:main Aug 22, 2023
5 checks passed
@SimonMarquis SimonMarquis deleted the patch-10 branch August 22, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dturner dturner dturner approved these changes

@mmoczkowski mmoczkowski mmoczkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Running MacroBenchmark Throw NullPointerException on interestsScrollTopicsDownUp
3 participants
@SimonMarquis @dturner @mmoczkowski