Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to Kotlin 1.9 #844

Closed
wants to merge 1 commit into from
Closed

Update project to Kotlin 1.9 #844

wants to merge 1 commit into from

Conversation

zsmb13
Copy link
Contributor

@zsmb13 zsmb13 commented Jul 18, 2023

Updates Kotlin to the latest version, adjusting KSP and Compose compiler versions accordingly. Updates Dagger to 2.47 get it to a newer version of kotlinx-metadata.

Change-Id: Ibef85a7a006d67e36fbb642ab0554493731bd49e
@@ -183,7 +183,7 @@ class NiaAppStateTest {
@Composable
private fun rememberTestNavController(): TestNavHostController {
val context = LocalContext.current
val navController = remember {
return remember<TestNavHostController> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required due to a lint bug https://issuetracker.google.com/291845885

@SimonMarquis
Copy link
Contributor

Hi @zsmb13 , there is currently another PR tracking the Kotlin 1.9 update #752 and there is still a blocking issue.

@zsmb13
Copy link
Contributor Author

zsmb13 commented Jul 19, 2023

Ah, sorry @SimonMarquis, let me bump Compose to stable over there and use that PR/branch then.

@zsmb13 zsmb13 closed this Jul 19, 2023
@SimonMarquis
Copy link
Contributor

SimonMarquis commented Jul 19, 2023

No worries, I can take care of that if you want me to (done). Although, Hilt could have been merged without updating the whole Kotlin stack.

@zsmb13 zsmb13 deleted the kotlin-1.9 branch July 19, 2023 07:32
@dturner dturner added version update This is related to a library, API or SDK update which requires some work. Not just a version bump. and removed version update This is related to a library, API or SDK update which requires some work. Not just a version bump. labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants