Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sample toolchains #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve sample toolchains #5

wants to merge 5 commits into from

Conversation

utzcoz
Copy link

@utzcoz utzcoz commented Oct 5, 2024

  1. Add gradlew binary to developers.
  2. Add GitHub's recommended gitignore for Android project.
  3. Add explicit jvmTarget to make it work with JDK22.
  4. Bump AGP and Kotlin's version to newer.

@utzcoz
Copy link
Author

utzcoz commented Oct 5, 2024

Friendly ping @tzhang997 for reviewing. Thanks.

@nicolas-raoul
Copy link

nicolas-raoul commented Oct 11, 2024 •
edited
Loading

The absence of gradlew is also surprising to me, since I usually build projects from command line (without opening Android Studio).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utzcoz @nicolas-raoul