Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab cataloger #2788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add GitLab cataloger #2788

wants to merge 1 commit into from

Conversation

RyanHopkins7
Copy link

@RyanHopkins7 RyanHopkins7 commented Apr 17, 2024

Adds a cataloger for GitLab installations meant to close #1904
I ran into a couple questions and problems while developing my new cataloger. I was hoping to get some help/direction in order to get this PR into a finalized state. It seems like some of the documentation about adding new catalogers might be a little bit outdated. Also, I just wanted to mention that I'm fairly new to open source. :)

Thank you!

@spiffcs
Copy link
Contributor

spiffcs commented May 7, 2024

👋 Hey @RyanHopkins7 thanks so much for the PR here!

The documentation mentions adding catalogers to the global list of catalogers, but it looks like this was removed by #1383. What should be the new process for adding a cataloger?

Great catch! I'll get that updated. In the meantime you can find catalogers initialized here:

newSimplePackageTaskFactory(arch.NewDBCataloger, pkgcataloging.DirectoryTag, pkgcataloging.InstalledTag, pkgcataloging.ImageTag, pkgcataloging.OSTag, "linux", "alpm", "archlinux"),

Which is called here:

factories := task.DefaultPackageTaskFactories()

You're right this needs a comprehensive update in the documentation. I'll get on that as soon as I have some time.

I'm a little unsure about the correct package URL format for GitLab. The PURL documentation mentions GitHub packages, and I tried to base my code off of that, but I'm not certain if that is correct or not.

Types to Define

It looks like they still have to define this. You're initial assumption seems good, but I would reach out and file an issue on their repo just to be sure =)

I ran the PR actions to show where we are as far as CI goes.

As to getting this into a final state. Let me see if I can take some time this week to help push this along for you.

@wagoodman
Copy link
Contributor

@RyanHopkins7 would you like help getting this across the finishline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Add a cataloger for GitLab installations
4 participants