Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass max time to download canary #281

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

willmurphyscode
Copy link
Contributor

This should help by highlighting slow downloads as failures in the github UI.

30 seconds to download the listing file and 120 seconds to download the database itself are the same as in Grype: https://github.com/anchore/grype/blob/57af1c34cb7db17824eac983cc6ae6945db47c88/cmd/grype/cli/options/database.go#L28-L29

Related to anchore/grype#1731

This should help by highlighting slow downloads as failures in the
github UI.

Signed-off-by: Will Murphy <[email protected]>
@spiffcs spiffcs merged commit 185e3f8 into main Apr 4, 2024
14 checks passed
@spiffcs spiffcs deleted the chore/timeout-on-download-canary branch April 4, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants