-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build system #115
Update build system #115
Conversation
Is it possible that it's not recognizing the |
@waebbl your suggestion worked, requiring C++ 11 fixed the MacOs OpenEXR 2 build issue. |
Yes it should, at least mostly. Some of that PR is outdated, some is fixed with my PR in conjunction with your changes to use GNUInstallDirs. |
one more build system question @waebbl, do you think we still need the files in
|
It depends. For the files in |
How could I preserve your additions and still edit the files I've changed, i.e. to clean up. Can I just |
@waebbl I pushed my additions to your forked repo waebbl/CTL update-build branch https://github.com/waebbl/CTL/tree/update-build so I think you can just do git pull on your update-build branch https://github.com/waebbl/CTL/tree/update-build |
@waebbl do you use the pkg-config files in your gentoo package? If not, I'd rather simplify and remove the pkg-config stuff. |
Thanks, I could just update it in the browser interface.
We currently don't have consumers of the ctl package, so we don't need the pkg-config files. I'm ok with dropping those. |
@waebbl i pushed a commit to your
If you don't see any issues with this, let me know and I'll merge the PR |
Use GNUInstallDirs variable throughout the build system. Bug: ampas#100 Signed-off-by: Bernd Waibel <[email protected]>
The search for OpenEXR and IlmBase resp. Imath dependencies can be simplified, as OpenEXR depends on either Imath or IlmBase, depending if we use <OpenEXR-3 or >=OpenEXR-3. Signed-off-by: Bernd Waibel <[email protected]>
The function enable_testing was globally enabled, no matter the value of the CMAKE_BUILD_TESTS option. This patch guards this call, so it only gets called, when CMAKE_BUILD_TESTS=ON. Signed-off-by: Bernd Waibel <[email protected]>
@michaeldsmith I cleaned up the code somewhat and actually removed the previously only commented lines of code. |
Thanks! |
The patches pick up some ideas from issue #100
CMAKE_BUILD_TESTS
variable. Guard the call of this function by the cmake option.Bug: #100
Signed-off-by: Bernd Waibel [email protected]