Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

87819: Handle throttling exceptions #13

Merged
merged 5 commits into from
Nov 6, 2023
Merged

87819: Handle throttling exceptions #13

merged 5 commits into from
Nov 6, 2023

Conversation

zoiec
Copy link
Contributor

@zoiec zoiec commented Oct 30, 2023 •
edited by dowied4
Loading

Adjust the retry logic to handle the exceptions so we can better see how this is failing (potentially if the failures continue).

ADO: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/87819

@dowied4 dowied4 force-pushed the 87139-Handle_throttling_exceptions branch from 0d053e6 to bdbca26 Compare November 6, 2023 16:16
@dowied4 dowied4 marked this pull request as ready for review November 6, 2023 16:16
@dowied4 dowied4 requested a review from a team as a code owner November 6, 2023 16:16
@dowied4 dowied4 changed the title 87139-87819-Handle_throttling_exceptions 87819-Handle_throttling_exceptions Nov 6, 2023
AnnelieseA
AnnelieseA previously approved these changes Nov 6, 2023
View reviewed changes
zoiec
zoiec commented Nov 6, 2023
View reviewed changes
Copy link
Contributor Author

@zoiec zoiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments

push/cloudwatch/event.rb Outdated Show resolved Hide resolved
subscribe/lambda/function.rb Outdated Show resolved Hide resolved
@zoiec zoiec dismissed AnnelieseA’s stale review November 6, 2023 22:06

I have left PR comments

zoiec
zoiec commented Nov 6, 2023
View reviewed changes
spec/push/cloudwatch/event_spec.rb Outdated Show resolved Hide resolved
spec/subscribe/lambda/function_spec.rb Outdated Show resolved Hide resolved
spec/subscribe/lambda/function_spec.rb Outdated Show resolved Hide resolved
@dowied4 dowied4 force-pushed the 87139-Handle_throttling_exceptions branch 2 times, most recently from 82b99ad to 957cb0a Compare November 6, 2023 23:47
@dowied4 dowied4 changed the title 87819-Handle_throttling_exceptions 87819: Handle throttling exceptions Nov 6, 2023
@dowied4 dowied4 force-pushed the 87139-Handle_throttling_exceptions branch from 957cb0a to 7b7cca3 Compare November 6, 2023 23:50
@dowied4 dowied4 force-pushed the 87139-Handle_throttling_exceptions branch from 7b7cca3 to 32bde71 Compare November 6, 2023 23:53
zoiec
zoiec commented Nov 6, 2023
View reviewed changes
Copy link
Contributor Author

@zoiec zoiec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@dowied4 dowied4 merged commit c04c19d into master Nov 6, 2023
4 checks passed
@dowied4 dowied4 deleted the 87139-Handle_throttling_exceptions branch November 6, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dowied4 dowied4 dowied4 approved these changes

@AnnelieseA AnnelieseA AnnelieseA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoiec @dowied4 @AnnelieseA