87139 - Capture Additional Tags to be sent to Loggly #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoiec
force-pushed
the
add_additional_tags_for_loggly
branch
from
60c64f5
to
689e73c
Compare
AB#87139 Changes - Added a method that will check the tags for a lambda and if any start with cloudwatch_loggly_tag it will get added as a tag when the logs are sent to loggly - Updated tests, Readme and Rubocop.yml file Test - This is deployed in the staging account for membership - Add a tag that starts with cloudwatch_loggly_tag to any lambda there and trigger the lambda - Go to loggly and search for the tag
zoiec
force-pushed
the
add_additional_tags_for_loggly
branch
from
689e73c
to
7a0afcd
Compare
zoiec
changed the title
README.md
Outdated
| @@ -50,6 +50,10 @@ If you wish to opt-out a Lambda function from Loggly delivery, add the `cloudwat | |||
|
|
|||
| By default, the value from the `FilterPatternParameter` is used when subscribing to CloudWatch log events. This value can be overridden on a per-function basis by setting the Lambda function's `cloudwatch_loggly_filter_pattern` tag to the value that you prefer. | |||
|
|
|||
| ### Adding tags to cloudwatch for a lambda | |||
|
|
|||
| By default, the only tags that will be sent to loggly are the ones specified in `LogTagsParameter`, the owner (account number) and the log group that the logs are from. If you would like to send additional tags then you must add a tag to the lambda that starts with `cloudwatch_loggly_tag`. For example a log group with the tag `cloudwatch_loggly_mfe: omninotes` will have the tag `omninotes` added to the loggly tags. | |||
There was a problem hiding this comment.
Should cloudwatch_loggly_mfe be cloudwatch_loggly_tag_mfe?
There was a problem hiding this comment.
@DessertMonster Yes Let me fix that, because that is important
DessertMonster
previously approved these changes
Oct 25, 2023
…dme suggested by Markdown Linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#87139
Changes
Test
This is deployed in the staging account for membership
Add a tag that starts with cloudwatch_loggly_tag to any lambda there and trigger the lambda
Go to loggly and search for the tag
I have written a detailed PR message and detailed commits explaining what is being changed and why