Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect use of g_error #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ungive
Copy link

@ungive ungive commented Mar 26, 2024

g_error() is only intended for programming errors that you cannot recover from. The way it is used here crashes the application when metadata could not be retrieved because of external factors.

Reference:

g_error is only intended for programming errors
that you cannot recover from.
this on the other hand is a recoverable error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant