Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in 'x-transitions' duration syntax #3808

Closed
wants to merge 1 commit into from

Conversation

itopizarro
Copy link

This changes the syntax of the reference example from x-transition.duration.500ms to x-transition:duration.500ms

@ekwoka
Copy link
Contributor

ekwoka commented Oct 12, 2023

But it's not a typo...

It is .duration

@itopizarro
Copy link
Author

Maybe it was my implementation?
I had an element with x-transition directives, where I was ok with setting both the enter and leave to the same value as follows:

<div x-show="showExample"
  x-transition:enter="foo"
  x-transition:leave="bar"
  x-transition.duration.1000ms>

But that didn't affect the duration at all. However, when I changed the instance regarding duration to x-transition:duration.1000ms it worked. I do see the need for the . notation when using x-transition:enter.duration.1000ms.

@itopizarro itopizarro closed this Oct 12, 2023
@ekwoka
Copy link
Contributor

ekwoka commented Oct 13, 2023

This is because you aren't supposed to mix value based transitions and the default transition helpers.

I can look more into it if/when I have time, but it's more of a "happy accident" that what you described worked...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants