✨ Names expression evaluators #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Utilizing Sentry on my team, this mention would certainly be beneficial. However, I suggest highlighting 'ALPINE' differently than using all capitals, perhaps through the use of an emoji or a less conspicuous tag like [AlpineJS] - '...the message...'" |
|
Good calls - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the expression as a name to the evaluator function. While Alpine logging information about the expression is helpful, many tools like sentry won't fully track or associate those warning logs with the actual error.
This change allows the expression to show as the name of the function in the stack trace itself making hunting down errors much easier.