fix: Entangle inner state undefined #3681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a serious Livewire issue for us where a
$wire.entangle()
was being removed after an AJAX request, which then causedinner
to beundefined
here, which crashed Livewire completely and made all further interactions break.To fix this, I've reached for the already-stringified
innerHashLatest
and ensured that it isnull
instead ofundefined
in this case. If you don't want to reuseinnerHashLatest
here, I can swap it back forJSON.stringify(inner ?? null)
.