Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed "traits" namespace to "trait" #1651

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

tonydp03
Copy link
Contributor

@tonydp03 tonydp03 commented Mar 16, 2022

Fixes #179. The Alpaka namespace "traits" was renamed to "trait" in all its occurrencies. However, are we sure we want to keep the namespace and not removing it entirely to simplify the code, as @bernhardmgruber suggested?

@psychocoderHPC
Copy link
Member

psychocoderHPC commented Mar 17, 2022

I am against removing the trait namespace. The namespace is separating the free functions the user is touching from the implementations alpaka developers or experts are providing. see https://alpaka-group.github.io/alpaka/namespaces.html

Copy link
Member

@bernhardmgruber bernhardmgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check every file, but I think trusting the CI is fine in this case.

@bernhardmgruber
Copy link
Member

The commit was made with @tonydp03 as author. @psychocoderHPC do you insist on commiting under the Tools author? And @j-stephan do you want @tonydp03 to update all the copyright headers? I don't care much about both of them.

Copy link
Member

@psychocoderHPC psychocoderHPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardmgruber mentioned it please commit your changes with

GIT_AUTHOR_NAME="Tools" GIT_AUTHOR_EMAIL="[email protected]" git commit ...

This PR is mostly processed with search and replace. We try to submit automated changes under an generic user.

@j-stephan
Copy link
Member

If we have the tools author I don't think we need to update the copyright header.

@tonydp03
Copy link
Contributor Author

I'll change the headers, rebase, and squash the new commit with the previous one under the Tools author.

@psychocoderHPC psychocoderHPC merged commit 9ec06cb into alpaka-group:develop Mar 21, 2022
@tonydp03 tonydp03 deleted the renameTraits branch May 10, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename traits to trait
4 participants