Issue-1164: REST Endpoints actually return a WP_Error if Apple News *is not* initialized
#1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatonascalves
deleted the
feature/issue-1164/rest-endpoints-return-wp-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1164
This PR addresses the issue where REST endpoints do not return a
WP_Errorif Apple News is not initialized. It includes the necessary code adjustments and unit tests to ensure the expected behavior is achieved.Description
Improvements have been made to the REST endpoints to ensure they properly return a
WP_Errorwhen Apple News is not initialized. The codebase has been updated accordingly.See https://github.com/search?q=repo%3Aalleyinteractive%2Fapple-news%20%5CApple_News%3A%3Ahas_uninitialized_error()%3B&type=code
Please, add unit tests.
Use Case
If Apple News is not initialized with the minimum settings, the REST API needs to return an error.