Fix: Get Unit tests passing for 2.4.1 #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exists In 6.4, WpOrg\Requests\Utility\CaseInsensitiveDictionary was introduced and using Requests_Utility_CaseInsensitiveDictionary will throw an exception
srtfisher
commented
Nov 15, 2023
| @@ -263,7 +263,9 @@ protected function add_http_response( | |||
| 'body' => $body, | |||
| 'cookies' => $cookies, | |||
| 'filename' => $filename, | |||
| 'headers' => new Requests_Utility_CaseInsensitiveDictionary( $headers ), | |||
| 'headers' => class_exists( \WpOrg\Requests\Utility\CaseInsensitiveDictionary::class ) | |||
There was a problem hiding this comment.
Change for WordPress 6.4 (I believe)
srtfisher
commented
Nov 15, 2023
| @@ -8,9 +8,6 @@ | |||
|
|
|||
| /* phpcs:disable WordPressVIPMinimum.Files.IncludingFile.UsingVariable */ | |||
|
|
|||
| const WP_TESTS_PHPUNIT_POLYFILLS_PATH = __DIR__ . '/../vendor/yoast/phpunit-polyfills'; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound | |||
|
|
|||
| const WP_TESTS_MULTISITE = 1; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound | |||
There was a problem hiding this comment.
Moved to the workflow matrix
attackant
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get tests passing on Apple News with TestKit.
Fixes #1027