Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix should prepended to items returned by list_prefix and list_dir methods #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Mar 31, 2021

Based on examples in the v3 spec, the prefix used as an argument to FileSystemStore's list_prefix and list_dir should show up in the output.

Example :

import zarrita
h = zarrita.get_hierarchy('../zarr_implementations/data/zarrita.zr3/')
h.store.list_prefix('meta/root/')

gives (after this PR):

['meta/root/blosc/lz4.array.json',
 'meta/root/gzip.array.json',
 'meta/root/raw.array.json',
 'meta/root/zlib.array.json']

vs. (before this PR)

['blosc/lz4.array.json',
 'gzip.array.json',
 'raw.array.json',
 'zlib.array.json']

Similarly, meta/root/ would now show up in a similar call to list_dir:
ListDirResult(contents=['meta/root/gzip.array.json', 'meta/root/zlib.array.json', 'meta/root/raw.array.json'], prefixes=['meta/root/blosc'])

@grlee77 grlee77 changed the title prefix should prepended to items returned by list_prefix and list_dir methods WIP: prefix should prepended to items returned by list_prefix and list_dir methods Mar 31, 2021
@grlee77
Copy link
Contributor Author

grlee77 commented Mar 31, 2021

Assuming this is the desired behavior, I will need to update the doctests accordingly

@grlee77 grlee77 changed the title WIP: prefix should prepended to items returned by list_prefix and list_dir methods prefix should prepended to items returned by list_prefix and list_dir methods Mar 31, 2021
@grlee77
Copy link
Contributor Author

grlee77 commented Mar 31, 2021

now the CI just has the previously known failure raised in #37

NickAkhmetov pushed a commit to NickAkhmetov/zarrita that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant