Performance: Optimize sub-queries for assets/apps against a given address. #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
==========================================
- Coverage 68.80% 68.69% -0.11%
==========================================
Files 38 38
Lines 7517 7529 +12
==========================================
Hits 5172 5172
- Misses 1915 1926 +11
- Partials 430 431 +1 ☔ View full report in Codecov by Sentry. |
jasonpaulos
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adopting the suggestions in #1595 , this PR aims to give significant speed ups in average query time by shrinking subquery app/asset result sets.
Test Plan
Existing unit/integration tests should all pass.