-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updates for Indexer 3.0.0 #1562
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1562 +/- ##
========================================
Coverage 68.58% 68.58%
========================================
Files 37 37
Lines 7417 7417
========================================
Hits 5087 5087
Misses 1903 1903
Partials 427 427 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of grammatical nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing we should probably add is the note to guide people who used to be on 2.x to the migration guide. As is, they'll come here and be confused.
@@ -322,13 +282,3 @@ When searching by an account, results are returned most recent first. The intent | |||
For all other transaction queries, results are returned oldest first. This is because it is the physical order they would normally be written in, so it is going to be faster. | |||
|
|||
<!-- USAGE_END_MARKER_LINE --> | |||
|
|||
# Migrating from Indexer v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have a "Migrating from Indexer 2.x" section here that just point to the Conduit version of that... And at least acknowledge that things were different in 2.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added something about this.
Co-authored-by: algoanne <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+16 −1,325
🔥
Summary
Update documentation to reflect Indexer 3.0.0. References to Indexer writers have been removed or replaced with references to Conduit.