Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: update module path and version #1558

Merged
merged 6 commits into from
Jul 11, 2023
Merged

bug-fix: update module path and version #1558

merged 6 commits into from
Jul 11, 2023

Conversation

shiqizng
Copy link
Contributor

@shiqizng shiqizng commented Jul 6, 2023

This PR resolves the problem stated in #1557

./algorand-indexer -v
3.0.0 compiled at 2023-07-06T19:04:37+0000 from git hash 61f0d133962bbec0a4bb680ead05f8e773a965f2 

curl "localhost:8980/health?pretty

{
    "data": {
        "migration-required": false,
        "read-only-mode": true
    },
    "db-available": true,
    "is-migrating": false,
    "message": "102",
    "round": 102,
    "version": "3.0.0"
}

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I don't think .version is used anymore, please delete it.
  • The LDFLAGS are also defined in .goreleaser.yaml

@winder winder requested a review from Eric-Warehime July 7, 2023 00:20
Makefile Outdated Show resolved Hide resolved
Co-authored-by: Will Winder <[email protected]>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1558 (d923103) into develop (61f0d13) will not change coverage.
The diff coverage is n/a.

❗ Current head d923103 differs from pull request most recent head bd0ba8c. Consider uploading reports for the commit bd0ba8c to get more accurate results

@@           Coverage Diff            @@
##           develop    #1558   +/-   ##
========================================
  Coverage    68.58%   68.58%           
========================================
  Files           37       37           
  Lines         7417     7417           
========================================
  Hits          5087     5087           
  Misses        1903     1903           
  Partials       427      427           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shiqizng shiqizng requested a review from winder July 7, 2023 13:43
@winder winder merged commit 6b6be24 into develop Jul 11, 2023
5 checks passed
@winder winder deleted the shiqi/fix branch July 11, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants