add high-priority stream flag using SetWriteDeadline magic value #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
reviewed
Oct 24, 2023
| @@ -490,7 +498,10 @@ func (s *Stream) SetReadDeadline(t time.Time) error { | |||
| func (s *Stream) SetWriteDeadline(t time.Time) error { | |||
| s.stateLock.Lock() | |||
| defer s.stateLock.Unlock() | |||
| if s.writeState == halfOpen { | |||
| // handle magic time.Time value to signal this is a high-priority stream. | |||
| if t.Equal(HighPriorityWriteDeadlineMagicValue) { | |||
There was a problem hiding this comment.
Why introduce this mechanism instead of addding an additional function to enable high priority?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a draft I had sitting around to provide high-priority send channel support similar to how we do sendBuffer prioritization in
wsPeer.writeLoophttps://github.com/algorand/go-algorand/blob/master/network/wsPeer.go#L814-L847