Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FNet: created "fnet2" protocol #6150

Open
wants to merge 30 commits into
base: dev/experimental-incentives
Choose a base branch
from

Conversation

tasosbit
Copy link

@tasosbit tasosbit commented Oct 9, 2024

Hardcoding the current future protocol as fnet2. This upgrade gates the new fields under the block opcode that were released with 3.26, which were not supported on the binary we released with the original fnet1 support.

Experimental / Not to be merged to main - The target branch dev/experimental-incentives is meant to facilitate FNet users who may want to build from source.

algorandskiy and others added 30 commits August 28, 2024 14:36
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 62.03655% with 727 lines in your changes missing coverage. Please review.

Project coverage is 56.20%. Comparing base (9855f57) to head (471d206).
Report is 64 commits behind head on dev/experimental-incentives.

Files with missing lines Patch % Lines
network/p2pNetwork.go 74.60% 76 Missing and 20 partials ⚠️
network/hybridNetwork.go 39.65% 65 Missing and 5 partials ⚠️
network/p2p/p2p.go 51.79% 62 Missing and 5 partials ⚠️
network/p2p/logger.go 0.00% 55 Missing ⚠️
network/p2p/http.go 0.00% 50 Missing ⚠️
daemon/algod/server.go 0.00% 48 Missing ⚠️
network/p2p/peerID.go 35.71% 19 Missing and 8 partials ⚠️
network/p2p/streams.go 0.00% 27 Missing ⚠️
data/txHandler.go 76.78% 17 Missing and 9 partials ⚠️
network/p2p/capabilities.go 61.19% 22 Missing and 4 partials ⚠️
... and 37 more
Additional details and impacted files
@@                       Coverage Diff                       @@
##           dev/experimental-incentives    #6150      +/-   ##
===============================================================
- Coverage                        56.34%   56.20%   -0.15%     
===============================================================
  Files                              486      494       +8     
  Lines                            68487    69961    +1474     
===============================================================
+ Hits                             38592    39323     +731     
- Misses                           27299    27962     +663     
- Partials                          2596     2676      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannotti
Copy link
Contributor

jannotti commented Oct 9, 2024

I was discussing current fnet activities with Patrick, and concluded that you probably want to turn off challenges until we have the heartbeat mechanism, or else you'll have accounts inexplicably suspended periodically.

Set Payouts.ChallengeInterval = 0

@tasosbit
Copy link
Author

turn off challenges

Will do but as a separate upgrade, as fnet2 has already been voted through and is scheduled to take effect on FNet in ~2 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants