Incentives: Heartbeat transaction type #13612
reviewdog.yml
on: pull_request
reviewdog-errors
3m 24s
reviewdog-warnings
3m 17s
reviewdog-shellcheck
12s
Annotations
7 errors and 1 warning
reviewdog-errors:
heartbeat/service_test.go#L43
[Lint Errors] reported by reviewdog 🐶
File is not `gofmt`-ed with `-s` (gofmt)
Raw Output:
heartbeat/service_test.go:43: File is not `gofmt`-ed with `-s` (gofmt)
for addr, _ := range p.accts {
|
reviewdog-errors:
ledger/apply/heartbeat.go#L34
[Lint Errors] reported by reviewdog 🐶
error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
Raw Output:
ledger/apply/heartbeat.go:34:21: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return fmt.Errorf("HeartbeatAddress %s has has no voting keys\n", hb.HeartbeatAddress)
^
|
reviewdog-errors:
ledger/apply/mockBalances_test.go#L294
[Lint Errors] reported by reviewdog 🐶
error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
Raw Output:
ledger/apply/mockBalances_test.go:294:47: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return bookkeeping.BlockHeader{}, fmt.Errorf("Round %v is not present\n", r)
^
|
reviewdog-errors:
ledger/eval/eval.go#L1715
[Lint Errors] reported by reviewdog 🐶
exported: exported function ActiveChallenge should have comment or be unexported (revive)
Raw Output:
ledger/eval/eval.go:1715:1: exported: exported function ActiveChallenge should have comment or be unexported (revive)
func ActiveChallenge(rules config.ProposerPayoutRules, current basics.Round, headers headerSource) challenge {
^
|
reviewdog-errors:
ledger/eval/eval.go#L1739
[Lint Errors] reported by reviewdog 🐶
exported: exported function FailsChallenge should have comment or be unexported (revive)
Raw Output:
ledger/eval/eval.go:1739:1: exported: exported function FailsChallenge should have comment or be unexported (revive)
func FailsChallenge(ch challenge, address basics.Address, lastSeen basics.Round) bool {
^
|
reviewdog-errors:
ledger/apply/heartbeat.go#L30
[Lint Errors] reported by reviewdog 🐶
ineffectual assignment to err (ineffassign)
Raw Output:
ledger/apply/heartbeat.go:30:11: ineffectual assignment to err (ineffassign)
account, err := balances.Get(hb.HeartbeatAddress, false)
^
|
reviewdog-errors
reviewdog exited with status code: 1
|
reviewdog-warnings
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|