Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add getter functions for logging interceptor fields #848

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

amarlankri
Copy link
Contributor

Description

Add the following public methods to LoggingInterceptor class:

  • getUserPrefix
  • getDisabledMasking
  • getMaskingPlaceholder
  • getMask

Motivation and Context

Setter methods are already provided for the related fields and usually, getters should be also provided by the class. For instance, it can be useful to retrieve the masking placeholder to apply it for masking other sensitive data, not handled by this interceptor.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@amarlankri amarlankri self-assigned this Feb 15, 2024
@amarlankri amarlankri added the enhancement New feature or request label Feb 15, 2024
Copy link
Contributor

@LeKer29 LeKer29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add small tests for these getters (just in case) ?

@g-ongenae g-ongenae merged commit 471ff54 into algoan:master Feb 16, 2024
4 checks passed
@amarlankri amarlankri deleted the logging/feat/add-getter branch February 16, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants